Open ilharp opened 1 year ago
@ilharp please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
@microsoft-github-policy-service agree [company="{your company}"]
Options:
- (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
- (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"
@microsoft-github-policy-service agree
Currently deployment samples
WV2DeploymentWiXCustomActionSample
andWV2DeploymentWiXBurnBundleSample
use the reg nameEBWebView
for registry searching, but this entry has already disappeared in recent versions of WVRT (also disappeared in Edge Stable).Changed them to
pv
, consistent withWV2DeploymentVSInstallerSample
.Also I noticed that these three registry searches were introduced in the same PR (#56). Are there any special considerations for the inconsistency here?
Related commit:
https://github.com/MicrosoftEdge/WebView2Samples/commit/8402697ac016014ca90a0168ef0059428102818e