ScenarioWebMessage.html says menuitem "IFrame Post Message JSON" instead of "Post Message JSON IFrame" - Githubissues

MicrosoftEdge / WebView2Samples

Microsoft Edge WebView2 samples

863 stars 466 forks source link

ScenarioWebMessage.html says menuitem "IFrame Post Message JSON" instead of "Post Message JSON IFrame" #191

Closed mikehoffms closed 8 months ago

mikehoffms commented 1 year ago

This issue is probably fixed by my PR https://github.com/MicrosoftEdge/WebView2Samples/pull/192.

Repro steps:

Run sample app "WebView2SampleAPISample".
Select Scenario > Web Messaging.
Scroll down to frame part of page.

Actual result:

The instructions in the frame say: Try using the menu item "Script->IFrame Post Message JSON" to send the message {"SetColor":"blue"}.
The menuitem reads: Script > Post Message String IFrame

Expected result:

The instructions in the frame should say: Try using the menu item "Script->Post Message JSON IFrame" to send the message {"SetColor":"blue"}.

To fix, maybe move the word "IFrame" to end of string in line 50 of https://github.com/MicrosoftEdge/WebView2Samples/blob/main/SampleApps/WebView2APISample/assets/ScenarioWebMessage.html Or change the menu item to start with "IFrame" instead of ending with that.

Screenshot after my fix: