search

MicrosoftEdge / static-code-scan

Run this quick static code scan on any URL to check for out-of-date libraries, layout issues and accessibility.
Other
1.05k stars 228 forks source link

Auth based unit test don't actually test auth code #99

Closed m-gagne closed 9 years ago

m-gagne commented 9 years ago

Description

The auth based unit tests don't actually apply code coverage to the express web app but rather uses a custom (test only) auth server (based on express). These tests not only currently do not work, but do not add value to the unit tests.

Recommendation

Remove the tests

molant commented 9 years ago

I think we should still have the auth tests (and probably improve them) for when NTLM support is added. That is going to change significantly how resources are downloaded and a few things could go wrong...

m-gagne commented 9 years ago

From what I can see in the code, they would need a rewrite, as they are not testing any actual production code, simply mimicking a basic auth server. We can revert the PR for this and comment out the code, but it didn't really do anything anyways.