MicrosoftLearning / 20483-Programming-in-C-Sharp

MIT License
13 stars 331 forks source link

Module 2 Exercise 3 solution is not complete #78

Closed nicktones closed 4 years ago

nicktones commented 5 years ago

Module 2 exercise 2 does not actually look like it's a complete solution, as per the instructions. The data does not save back to the database.

hamilton7 commented 4 years ago

Any update on this ?

JonGonard commented 4 years ago

Hi, I apologize for the lateness of my response.

I've checked the exercise (I suppose you meant exercise 3), and it looked alright to me. could you please elaborate on the issue?

Thanks

hamilton7 commented 4 years ago

After you press the button "Save Changes" the changes do not save back to the database.

I am using the (localdb)\MSSQLLocalDB. The data is displayed correctly, however something goes wrong with the saveChanges_Click method.

If I ran the solution, I am getting the below errors: I googled them, tried different things but without success.

$exception {"The underlying provider failed on Open."}

InnerException {"The operation is not valid for the state of the transaction."}

JonGonard commented 4 years ago

These exceptions happened only on the save changes method? That's odd, I haven't seen anything like that.

Do you have Live Share on your VS? Or perhaps TeamViewer? I could connect to your session and try to debug it. I will be available for it at around 6pm GMT, is that OK?

JonGonard commented 4 years ago

I think I've found the issue, fixed with commit f92f363a23eb870a73823270fed5cfede8cb4e09 Try to run the Module 2 Exercise 3 solution, please let me know if the issue persists.

hamilton7 commented 4 years ago

Sorry for my late repose (due to the different time zone)

Problem solved!

I've just tested it and it works smoothly now. What was the issue ?

thank you very much, MIchael


From: JonGonard notifications@github.com Sent: 07 October 2019 09:47 To: MicrosoftLearning/20483-Programming-in-C-Sharp 20483-Programming-in-C-Sharp@noreply.github.com Cc: Michael michael1_7@msn.com; Comment comment@noreply.github.com Subject: Re: [MicrosoftLearning/20483-Programming-in-C-Sharp] Module 2 Exercise 3 solution is not complete (#78)

I think I've found the issue, fixed with commit f92f363https://github.com/MicrosoftLearning/20483-Programming-in-C-Sharp/commit/f92f363a23eb870a73823270fed5cfede8cb4e09 Try to run the Module 2 Exercise 3 solution, please let me know if the issue persists.

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/MicrosoftLearning/20483-Programming-in-C-Sharp/issues/78?email_source=notifications&email_token=AAIPYFVMFLLD7JIDLNTMRBDQNLLPNA5CNFSM4IMGHCO2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAPGA3I#issuecomment-538861677, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AAIPYFVVMCIFLN3N3XNZLCLQNLLPNANCNFSM4IMGHCOQ.

JonGonard commented 4 years ago

Two things,

The code created a TransactionScope but never used it, so the transaction remained opened. The TransactionScope was also created before the connection, which is what may have led to the "Invalid transaction state" exception. I've removed the TransactionScope completely from that exercise.

Also, The code opened the connection but never closed it, so I'm now disposing the schoolContext in the Window_Unloaded event.

hamilton7 commented 4 years ago

Thanks a lot JonGonard.

Have a nice day ahead.


From: JonGonard notifications@github.com Sent: 07 October 2019 15:05 To: MicrosoftLearning/20483-Programming-in-C-Sharp 20483-Programming-in-C-Sharp@noreply.github.com Cc: Michael michael1_7@msn.com; Comment comment@noreply.github.com Subject: Re: [MicrosoftLearning/20483-Programming-in-C-Sharp] Module 2 Exercise 3 solution is not complete (#78)

Two things,

The code created a TransactionScope but never used it, so the transaction remained opened. The TransactionScope was also created before the connection, which is what may have led to the "Invalid transaction state" exception. I've removed the TransactionScope completely from that exercise.

Also, The code opened the connection but never closed it, so I've closed it in the Window_Unloaded event.

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/MicrosoftLearning/20483-Programming-in-C-Sharp/issues/78?email_source=notifications&email_token=AAIPYFSHRB2JWHAELES5MK3QNMQYPA5CNFSM4IMGHCO2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAQCISQ#issuecomment-538977354, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AAIPYFUP22U3G5AUTVXNJITQNMQYPANCNFSM4IMGHCOQ.

hamilton7 commented 4 years ago

Dear All,

In Module 8, Exercise 2 has following url http://localhost:1655/Services/GradesWebDataService.svc/$metadata

However, every time we getting the below error:

[cid:9ba6da42-5211-4701-9658-2089774563d6]

[cid:2ae062f6-80f6-488a-93f7-2957d84ff65e]

Can you please assist ?

thanks, Michalis


From: Michalis Nikolaou michael1_7@msn.com Sent: 08 October 2019 08:44 To: MicrosoftLearning/20483-Programming-in-C-Sharp 20483-Programming-in-C-Sharp@noreply.github.com; MicrosoftLearning/20483-Programming-in-C-Sharp reply@reply.github.com Cc: Comment comment@noreply.github.com Subject: Re: [MicrosoftLearning/20483-Programming-in-C-Sharp] Module 2 Exercise 3 solution is not complete (#78)

Thanks a lot JonGonard.

Have a nice day ahead.


From: JonGonard notifications@github.com Sent: 07 October 2019 15:05 To: MicrosoftLearning/20483-Programming-in-C-Sharp 20483-Programming-in-C-Sharp@noreply.github.com Cc: Michael michael1_7@msn.com; Comment comment@noreply.github.com Subject: Re: [MicrosoftLearning/20483-Programming-in-C-Sharp] Module 2 Exercise 3 solution is not complete (#78)

Two things,

The code created a TransactionScope but never used it, so the transaction remained opened. The TransactionScope was also created before the connection, which is what may have led to the "Invalid transaction state" exception. I've removed the TransactionScope completely from that exercise.

Also, The code opened the connection but never closed it, so I've closed it in the Window_Unloaded event.

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/MicrosoftLearning/20483-Programming-in-C-Sharp/issues/78?email_source=notifications&email_token=AAIPYFSHRB2JWHAELES5MK3QNMQYPA5CNFSM4IMGHCO2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAQCISQ#issuecomment-538977354, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AAIPYFUP22U3G5AUTVXNJITQNMQYPANCNFSM4IMGHCOQ.

hamilton7 commented 4 years ago

Dear All,

In Module 8, Exercise 2 has following url http://localhost:1655/Services/GradesWebDataService.svc/$metadata

However, every time we getting the below error:

[cid:9ba6da42-5211-4701-9658-2089774563d6]

[cid:2ae062f6-80f6-488a-93f7-2957d84ff65e]

Can you please assist ?

thanks, Michalis

JonGonard commented 4 years ago

This issue is closed and the request is unrelated, I saw you've opened a new issue, please post all relevant data there