Closed ksaye closed 11 months ago
Thank you for creating the PR. Interestingly, I can't reproduce your error. Are you running the code in a Cloud Shell or on a local machine?
I am running it on a terminal on a compute resource, per the instructions.
From: madiepev @.> Sent: Thursday, October 5, 2023 3:25 PM To: MicrosoftLearning/mslearn-azure-ml @.> Cc: Kevin Saye @.>; Author @.> Subject: Re: [MicrosoftLearning/mslearn-azure-ml] Update setup.sh resolve "Bad substitution" (PR #57)
Thank you for creating the PR. Interestingly, I can't reproduce your error. Are you running the code in a Cloud Shell or on a local machine?
- Reply to this email directly, view it on GitHubhttps://github.com/MicrosoftLearning/mslearn-azure-ml/pull/57#issuecomment-1749592134, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ADY2O5E5KR22342UIOIZ4DDX54JSHAVCNFSM6AAAAAA5UTRA76VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONBZGU4TEMJTGQ. You are receiving this because you authored the thread.Message ID: @.**@.>>
Could you specify exactly which part of which instructions you mean? The instructions specify to run the setup script in a cloud shell.
Re reading it, I think you are right. I always just used the terminal on the Compute node.
Please feel free to close / reject this pr.
From: madiepev @.> Sent: Thursday, October 5, 2023 3:29 PM To: MicrosoftLearning/mslearn-azure-ml @.> Cc: Kevin Saye @.>; Author @.> Subject: Re: [MicrosoftLearning/mslearn-azure-ml] Update setup.sh resolve "Bad substitution" (PR #57)
Could you specify exactly which part of which instructions you mean? The instructions specify to run the setup script in a cloud shell.
- Reply to this email directly, view it on GitHubhttps://github.com/MicrosoftLearning/mslearn-azure-ml/pull/57#issuecomment-1749596440, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ADY2O5BINQO2RVVW64XMWP3X54KARAVCNFSM6AAAAAA5UTRA76VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONBZGU4TMNBUGA. You are receiving this because you authored the thread.Message ID: @.**@.>>
Thanks for verifying! I'll close this for now but let us know if you encounter any other issues.
Using the shell replace commands in line 5 and 6 requires bash as sh does not support it AFAIK. If accepted, this change should be applied to all the "setup.sh".
Without this change you will get a "Bad substitution" error:
./setup.sh: 5: Bad substitution
uname -a Linux kevinsay2 5.15.0-1040-azure #47~20.04.1-Ubuntu SMP Fri Jun 2 21:38:08 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
(azureml_py38) azureuser@kevinsay2:~/cloudfiles/code/Users/kevinsay/azure-ml-labs/Labs/03$ echo $0 /bin/bash
Module: 00
Lab/Demo: 00
Fixes # .
Changes proposed in this pull request:
-
-