MicrosoftPremier / VstsExtensions

Documentation and issue tracking for Microsoft Premier Services Visual Studio Team Services Extensions
MIT License
59 stars 14 forks source link

Cleanup doesn't use the YAML clean option #119

Closed benventive closed 7 months ago

benventive commented 4 years ago

Hello,

When using PostBuildCleanup in YAML with Azure Pipelines, it seems that the cleanup option set in YAML (https://docs.microsoft.com/en-us/azure/devops/pipelines/process/phases?view=azure-devops&tabs=yaml#workspace) is ignored in favored of the one set in the pipeline options. One easy workaround is to align the 2 options but, ideally, the YAML option should take precedence in this step, just as in the checkout step.

Thanks!

ReneSchumacher commented 4 years ago

Hi @benventive,

the Post Build Cleanup extension is still not really supported for YAML pipelines as those pipelines do not use the default variables of the older pipeline model. We'll need to update the task to make it compatible.

jamers99 commented 2 years ago

@ReneSchumacher are there plans for this to be done? I really need this functionality in our YAML pipelines. It works for most, but then some random ones don't work. This is a great tool that I would love to use more!

ReneSchumacher commented 2 years ago

@jamers99 Sorry for not getting back to you sooner. It's currently a pretty busy time here at Microsoft. See my comment at https://github.com/MicrosoftPremier/VstsExtensions/issues/162#issuecomment-1127538576. We're now actively working on a YAML version of the task.

ReneSchumacher commented 7 months ago

Finally closing this issue. We have updated our docs and provided workarounds for achieving the same cleanup without our task. The task has only limited support for YAML and we will not improve the compatibility, as we cannot be 100% compatible. Thus, we released guidance in our docs.