MicrosoftPremier / VstsExtensions

Documentation and issue tracking for Microsoft Premier Services Visual Studio Team Services Extensions
MIT License
57 stars 14 forks source link

Build Quality checks for Node repos ? #19

Closed vladbarosan closed 5 years ago

vladbarosan commented 5 years ago

Hello, We are trying to use the Build Quality Checks task for our repo (which is a node app) but it doesnt seem to work.

The only output we get is:

2018-10-23T00:20:28.7761367Z Waiting for code coverage data... 2018-10-23T00:20:31.0172524Z Waiting for code coverage data... 2018-10-23T00:20:33.2352164Z Waiting for code coverage data... 2018-10-23T00:20:35.4701525Z Waiting for code coverage data... 2018-10-23T00:20:37.6715337Z Waiting for code coverage data... 2018-10-23T00:20:39.4527516Z Unable to get code coverage data within the maximum wait time. 2018-10-23T00:20:39.4540471Z Total branches: 0 2018-10-23T00:20:39.4540714Z Covered branches: 0 2018-10-23T00:20:39.4541018Z Code Coverage (%): 0 2018-10-23T00:20:39.4961462Z ##[section]Finishing: Check build quality

is there anything we are doing wrong ? we are using cobertura, lcov, html, json etc for coverage reporting.

Do we need a publish test coverage task also ?

ReneSchumacher commented 5 years ago

Hi Vlad,

our task does not calculate coverage values itself. It merely uses the data that has been published to Team Foundation Server or Azure DevOps Services by another task (e.g., Visual Studio Test task, Publish Code Coverage Results task). We'll clarify that in our docs as a couple users have had similar questions.

Please let me know if you need anything else! René

ReneSchumacher commented 5 years ago

Hi Vlad,

since I haven't received any feedback from you I'm assuming that you resolved your issue. Therefore, I'm closing this issue for now. If you need additional help, please let us know or open another issue.

Happy building! René

vladbarosan commented 5 years ago

@ReneSchumacher yes, for future reference, a task that publishes test coverage is required ( just doing test coverage is not enough)