MiczFlor / RPi-Jukebox-RFID

A Raspberry Pi jukebox, playing local music, podcasts, web radio and streams triggered by RFID cards, web app or home automation. All plug and play via USB. GPIO scripts available.

http://phoniebox.de

MIT License

1.33k stars 395 forks source link

🐛 | RFID Card can be assigned to several system commands #1013

Open jo-me opened 4 years ago

jo-me commented 4 years ago

Bug

What I did

Assign a RFID card ID to 2 system commands via the web UI

What happened

The card ID is assigned to setVolume 75% and setMaxVolume 75% because I chose the wrong command at first.

Swiping the card will only change the maxVolume, so I assume that executing several commands with one swipe is not really working and should therefore be prohibited (at least when it is configured in the UI).

I expected this to happen

The ID should've been unassigned from the old system command and assigned to the new system command.

Further information that might help

Software

Base image and version

Raspberry OS

Branch / Release

2.0 - ed888da - master

Installscript

buster classic

Hardware

RaspberryPi version

RFID Reader

RC522

Soundcard

Miniamp

MiczFlor commented 4 years ago

I @jo-me I knew that was the case :) the web UI was a quick hack on my side to allow assigning system stuff to cards at all. Beforehand it had to be done with the editor. But you are right, that should be the way it's working. And I changed it to enhancement. Bug is such an ugly word.

alfrepo commented 3 years ago

Hi @MiczFlor - I have just set up the Phoniebox project for the kidz and have faced the same behaviour. Multiple commands are assigned to the same card. Also something like "unassign card" or "unregister card" from everywhere would be useful I guess.

I would like to enhance the UI a bit - can you point me to the right part of the project? Where should I look for the relevant code?

Is there an easy way to deploy the modified code to the PI, to test it? Would copy/paste to the ~/RPi-Jukebox-RFID do it?

s-martin commented 4 months ago

2317 tracks the implementation of the desired feature in V3.

We will not implement this for V2, please follow up there.

AlvinSchiller commented 3 months ago

@s-martin isn't this really a bug than a feature request? Two Commands on the same id shouldn't be possible, as only the first matched command will be executed. But which one is not visible to the user, as the order in the ui and the backend differs.

s-martin commented 3 months ago

You are right, didn't read it correctly.

I'm reopening the issue