Fix PlayerMPD.prev/next() when stopped

MiczFlor / RPi-Jukebox-RFID

A Raspberry Pi jukebox, playing local music, podcasts, web radio and streams triggered by RFID cards, web app or home automation. All plug and play via USB. GPIO scripts available.

http://phoniebox.de

MIT License

1.3k stars 394 forks source link

Fix PlayerMPD.prev/next() when stopped #2326

Closed hoffie closed 2 months ago

hoffie commented 2 months ago

Fix PlayerMPD.prev/next() when stopped

Avoid MPD-related crashes during all prev/next() calls.
Explicitly handle prev() in stopped state, configurable via playermpd.stopped_prev_action.
Explicitly handle next() in stopped state, configurable via playermpd.stopped_next_action.
Explicitly handle next() when reaching the end of the playlist: jukebox-daemon will now ignore the action by default (similar to v2). It can also be configured to rewind the playlist instead by setting the new config option playermpd.end_of_playlist_next_action: rewind or to stop playing.

Fixes #2294 Fixes #2327

coveralls commented 2 months ago

Pull Request Test Coverage Report for Build 8661575867

Details

1 of 6 (16.67%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.1%) to 38.235%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
src/jukebox/jukebox/utils.py	1	6	16.67%
<!--	Total:	1	6	16.67%	-->

Totals
Change from base Build 8605260930:	-0.1%
Covered Lines:	494
Relevant Lines:	1292

💛 - Coveralls

s-martin commented 2 months ago

No action could be a third option, but that could also be added in a later PR.

https://github.com/MiczFlor/RPi-Jukebox-RFID/issues/2327#issuecomment-2050522393

hoffie commented 2 months ago

No action could be a third option, but that could also be added in a later PR.

Added now.

As there have been further changes for #2327, this PR needs another review and new testing (I haven't tested the most recent state yet, maybe @igorwalton can help?).