search

MiczFlor / RPi-Jukebox-RFID

A Raspberry Pi jukebox, playing local music, podcasts, web radio and streams triggered by RFID cards, web app or home automation. All plug and play via USB. GPIO scripts available.
http://phoniebox.de
MIT License
1.3k stars 394 forks source link

🚀 | "next_song" performing no action when no next song is available #2327

Closed IgorWalton closed 2 months ago

IgorWalton commented 2 months ago

Feature

I would like the next_song GPIO button to do nothing, when there is no next song available (last track of a folder or single track without any folder). Currently this will stop the playback.

User perspective

I imagine my (very young) child will pretty randomly press all of the available buttons, so this behaviour would be better suited.

Further information

using Jukebox Core Version 3.5.2

Lippsson commented 2 months ago

Good feature request. It would be great if that above is the standard behavior

pabera commented 2 months ago

I think this is what the following PR is trying to solve?!

hoffie commented 2 months ago

Hrm, the linked PR will behave in the following way:

  1. When the last song of a playlist is being played and next() is called, the default will be to stop playing (this is configurable).
  2. When the player is stopped (e.g. because the last song of a playlist finished) and the next() is called, the player will rewind the playlist (i.e. it will start playing the first song of the playlist again).

@IgorWalton Is that what you're after? If not, we would have to make (2) configurable as well.

IgorWalton commented 2 months ago
  1. I personally would prefer if the default is "no action" in this situation
  2. The way I think would make the most sense is during a stop in the middle of a track "next" jumps to the next track in the current playlist, and at the end of a playlist it there's either "no action" or "start playing the first song of the playlist" I don't have the developer perspective (yet), so just 2 Cents from a User's POV...
hoffie commented 2 months ago

Edit: I'm updating #2326 to add the no action behavior for (1). Regarding (2), this can certainly be implemented as well. I was a bit hesitant to make this configurable, because every option adds code and config complexity, but I guess it's worth it if there are people who want to use it like that. :)

s-martin commented 2 months ago

You can still add it, if you want

hoffie commented 2 months ago

I personally would prefer if the default is "no action" in this situation

2326 should now technically cover this.

The way I think would make the most sense is during a stop in the middle of a track "next" jumps to the next track in the current playlist

Done.

at the end of a playlist it there's either "no action" or "start playing the first song of the playlist"

This should now behave similar to the case when running next() while playling the last song of the playlist (= it's configurable).

s-martin commented 2 months ago

2326 has been merged to future3/develop