MiczFlor / RPi-Jukebox-RFID

A Raspberry Pi jukebox, playing local music, podcasts, web radio and streams triggered by RFID cards, web app or home automation. All plug and play via USB. GPIO scripts available.
http://phoniebox.de
MIT License
1.35k stars 397 forks source link

feat: Add resume position tracking for all play types #2331

Open hoffie opened 5 months ago

hoffie commented 5 months ago

The tracking is active by default, but the resuming has to be enabled explicitly, either by setting playermpd.play_position_tracking.resume_by_default: true or by calling the play_* functions with the new resume=True kwarg.

Related: #1946

Reasons for draft status / checklist before merging:

I've been using most of the code on my Phoniebox without problems. The code has seen some adjustments by now though, so it hasn't been tested as-is. Other than that, it's ready for review. I will do a final round of testing when the reviews are done.

Previous review by @pabera (most of the actionable items should have been incorporated by now): https://github.com/hoffie/RPi-Jukebox-RFID/commit/c4805cebb848e8aaafd69c43f497b09436e67169

coveralls commented 5 months ago

Pull Request Test Coverage Report for Build 8653786800

Details


Totals Coverage Status
Change from base Build 8605260930: 0.0%
Covered Lines: 493
Relevant Lines: 1286

💛 - Coveralls