Fix button SecondFunc trigger

[AlvinSchiller]

I had this change laying around for some time, but with the gathered reports in https://github.com/MiczFlor/RPi-Jukebox-RFID/issues/1666 it may be worth to bring it in.

---

Introduce changes to the button function calling behavior, to not trigger both function if the button is held. Though this behavior is documented, it is still counter intuitive and likely the uncommon case.

For the "SecondFunc" hold_mode the new behavior is:

• SecondFunc
  • only main function is executed if button is NOT held past hold_time
  • only secondary function is executed if button is held past hold_time
• SecondFuncRepeat
  • only main function is executed if button is NOT held past hold_time
  • only secondary function is executed if button is held past hold_time and repeatedly if button is futher held past hold_time

Other hold_modes have not been affected and behave the same:

• None (no changes)
  • main function is executed instantly
• Repeat (no changes)
  • main function is executed instantly and repeatedly if button is held past hold_time
• Postpone (no changes)
  • main function is executed if button is held past hold_time

closes https://github.com/MiczFlor/RPi-Jukebox-RFID/issues/1666

[coveralls]

Pull Request Test Coverage Report for Build 9009259380

Details

• 14 of 14 (100.0%) changed or added relevant lines in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.04%) to 78.547%

---

Totals
Change from base Build 8928871385:	0.04%
Covered Lines:	454
Relevant Lines:	578

---

💛 - Coveralls

[AlvinSchiller]

@s-martin not sure if we should just change the behavior and explain the changes in the release notes (and needed updates for existing configurations). Or make this new behavior activatable via a new parameter for the button (or activate the old behavior as the new should be the more common case).

I personally dont see a usecase where its usefull to trigger both functions, but they maybe exist.

[s-martin]

For me the new behavior you implemented is more intuitive and consistent.

I don't have a comprehensive upgrade path for that behavior change. My suggestion would be to clearly state this as a breaking change in the release notes. Additionally we should make sure that we update all documentation (also in the wiki and maybe even make a quick search in the (closed) issues to add a comment, if necessary).

[AlvinSchiller]

I don't have a comprehensive upgrade path for that behavior change. My suggestion would be to clearly state this as a breaking change in the release notes. Additionally we should make sure that we update all documentation (also in the wiki and maybe even make a quick search in the (closed) issues to add a comment, if necessary).

I don't see an update path aswell. I added an alert to the component docs. The wiki didn't have any references that were this specific. All relevant tickets i found are already linked in the referenced issue. I will add a note to them if this is merged.