search

MiczFlor / RPi-Jukebox-RFID

A Raspberry Pi jukebox, playing local music, podcasts, web radio and streams triggered by RFID cards, web app or home automation. All plug and play via USB. GPIO scripts available.
http://phoniebox.de
MIT License
1.3k stars 394 forks source link

Cloning master had connection issues #2375

Open mzaiss opened 1 month ago

mzaiss commented 1 month ago

https://github.com/MiczFlor/RPi-Jukebox-RFID/blob/3431ba1a1b8865796fa618b8a0c4a257c842c25f/scripts/installscripts/install-jukebox.sh#L913

I suggest adding --depth 1 in the clone line.

I get this error otherwise: grafik

mzaiss commented 1 month ago

also pip module was not found for master installation. i ran:

sudo apt install python3-pip

to resolve

s-martin commented 1 month ago

I think your connection broke while cloning, so it was not completed. Maybe try to put your box closer to the WiFi router.

I think all other errors are because of the not succeeded cloning.

mzaiss commented 1 month ago

Probably, but I got this error repeatedly. And --depth 1 solves it. On the device there is also no reason not to not run --depth 1, is it?

s-martin commented 1 month ago

I agree depth 1 could be a good idea.

s-martin commented 1 month ago

Maybe --single-branch in addition to the current command is useful, because it doesn’t fetch all the other branches.

s-martin commented 1 month ago

This looks like a good overview: https://github.blog/2020-12-21-get-up-to-speed-with-partial-clone-and-shallow-clone/

From the article a „blobless clone“ (git clone --filter=blob:none <url>) looks like a good compromise.

A „shallow clone“ (git clone --depth=1 <url>) would also work for just building a Phoniebox, but when a user decides later to develop on that clone they would run into issues.

@AlvinSchiller @pabera @Groovylein

AlvinSchiller commented 1 month ago

I compared the commands for used space after initial clone with checked out "develop": Full: ~44MB NoBlob: ~29MB NoTree: ~27MB Depth 1: ~26MB

IF we want to make a change here, i also would vote for the --filter=blob:none option, as it has reduced size and the least side effects, with development usecases.

@mzaiss Nevertheless would be interesting, why this causes trouble in your setup, if it is not network related.

s-martin commented 1 month ago

@mzaiss did you check again? I still suspect a temporary issue like bad WiFi or a server, which is down. But if the issue still persists for you, we should investigate deeper.

mzaiss commented 1 month ago

i havent reinstalled since then, but suggest depth 1 as standard to save time and memory.

s-martin @.***> schrieb am Di., 4. Juni 2024, 23:19:

@mzaiss https://github.com/mzaiss did you check again? I still suspect a temporary issue like bad WiFi or a server, which is down. But if the issue still persists for you, we should investigate deeper.

— Reply to this email directly, view it on GitHub https://github.com/MiczFlor/RPi-Jukebox-RFID/issues/2375#issuecomment-2148433042, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB7RKGRF2QWJIMWFJX4OQ7LZFYVMJAVCNFSM6AAAAABH5XHUDWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNBYGQZTGMBUGI . You are receiving this because you were mentioned.Message ID: @.***>