🐛 | bookworm: check for raspian not working

[mittler-works]

Version

3.5.3

Branch

future3/main

OS

Raspberry Pi OS Bookworm Lite

Pi model

Zero 2W

Hardware

No response

What happened?

When running the installer script, it fails saying

ERROR: '<something>' found more than once in 'unknown'

Where <something> is not always the same thing.

I tracked it down, the problem is the check for Raspian here.

Newer releases of Raspberry Pi OS (bookworm) do not display raspian in /etc/os-release no more, but just debian. So there is no way to really tell if we are on Raspberry Pi OS. I have found articles that propose to check the existence of /etc/apt/sources.list.d/raspi.list to determine if we are on Raspberry Pi OS. Although this is obviously not perfect either, it might be a better solution than consulting /etc/os-release for the future.

Logs

No response

Configuration

No response

More info

No response

[mittler-works]

This only seems to affect bookworm 64bit. bookworm 32 bit shows raspian, as usual.

[s-martin]

At this time 64bit is not supported (there's also a check for it).

[mittler-works]

I know that (I had to bypass the check :smile: ), but I'm always interested in trying things out. ;-) Basically, bookworm/64bit is already running quite decent. It's just little things; but I think it's important to track them, even if the software is currently not supporting it. That might save a bit of work for future later. :wink:

[s-martin]

Basically, bookworm/64bit is already running quite decent. It's just little things; but I think it's important to track them, even if the software is currently not supporting it. That might save a bit of work for future later. :wink:

I agree.

We also happily discuss possible changes for a working 64bit implementation, so if anybody opens a PR with necessary changes interested people could review it. I know @alesrosina did also make it work (see #2313)

[alesrosina]

Basically, bookworm/64bit is already running quite decent. It's just little things; but I think it's important to track them, even if the software is currently not supporting it. That might save a bit of work for future later. 😉

I agree.

We also happily discuss possible changes for a working 64bit implementation, so if anybody opens a PR with necessary changes interested people could review it. I know @alesrosina did also make it work (see #2313)

Yes, basically I just removed all checks in setup script. And then it's running as it should on 64bit.

I probably should take the time to make a PR, but probably not before autumn, since in summer time i prefer to be outside in my free time ;)

[mittler-works]

I can prepare a PR to lift the 64 bit restriction. It would only be a change in the install-jukebox.sh (removing _check_os_type) and the thing with the Raspian check. There I would then use an or-condition in terms of "Either the os-release property ID contains raspian or the file /etc/apt/sources.list.d/raspi.list exists and contains corresponding raspian sources".

I've found no other issues with 64 bit. The GPIO Problems with kernel 6.6 upwards mentioned in the other issue are not specific to 64 bit, but also affect 32 bit, right? So that wouldn't be a show stopper for lifting 64 bit restriction, I think.

[alesrosina]

I can prepare a PR to lift the 64 bit restriction. It would only be a change in the install-jukebox.sh (removing _check_os_type) and the thing with the Raspian check. There I would then use an or-condition in terms of "Either the os-release property ID contains raspian or the file /etc/apt/sources.list.d/raspi.list exists and contains corresponding raspian sources".

I've found no other issues with 64 bit. The GPIO Problems with kernel 6.6 upwards mentioned in the other issue are not specific to 64 bit, but also affect 32 bit, right? So that wouldn't be a show stopper for lifting 64 bit restriction, I think.

Yes, from my experience that's correct :+1: