search

MidFidelity / TINF21C_Team2_AAS_digital_nameplate

Generator for digital nameplates for assets in an Asset Administration Shell
https://midfidelity.github.io/TINF21C_Team2_AAS_digital_nameplate/
MIT License
4 stars 0 forks source link

Nameplate Review #117

Closed mariskoch closed 1 year ago

mariskoch commented 1 year ago

Dear customer (@mrentsch65),

the nameplates are now visible and ready for download in the asset view. Also, all Servers (admin-shellV1, admin-shellV3, Murrelektronik) are supported. We would appreciate feedback on the namplate design.

Important

If you want to access the Murrelektronik Server, you need to enable mixed requests in your browser.

If you want to access the admin-shell servers, make you sure you disable cors (install add-on for that).

mrentsch65 commented 1 year ago

Good Work :-) I have the following remarks:

1) Follow the guidelines in IEC 63365 ch. 5.1.2 "Symbol design" and put in the marking characters "IEC63365" at the bottom of the QR code:

image

2) Encode the AssetId as URI on top of the data in the QR-Code: 3) Separate the manufacturerer address on the nameplate optically as indicated here:

image

4) Do not print the idShort on the nameplate: 5) Do not print marking texts and the marking icons simultaneously on the nameplate:

image

mrentsch65 commented 1 year ago

https://mk28.github.io/TINF21C_Team2_AAS_digital_nameplate/?searchTerm=#/asset/Murrelektronik_V000_PS048_0100001_AAS_SN01234564?server=http%3A%2F%2Faas.murrelektronik.com%3A4001%2Faas

Why are the following data not fetched from the AAS nameplate submodel?

image

MurrTenkeu commented 1 year ago

You need to check also for the new Nameplate Submodel Version: https://admin-shell.io/zvei/nameplate/2/0/Nameplate See this link: https://github.com/admin-shell-io/submodel-templates/tree/main/published/Digital%20nameplate/2/0 Best Regard Alain

mrentsch65 commented 1 year ago

Yes, there seems to be a bug regarding the submodel selection: image

MurrTenkeu commented 1 year ago

image

The AAS REST API Call performed by Nameplate Generator provides the response messages result as the AAS REST API Call performed via the firefox web browser, and the data in the response messages(submodels) are also correct. The error occurs during the parsing process of the Submodel Nameplate

Best regards Alain

mariskoch commented 1 year ago

Dear customer (@mrentsch65),

all 5 remarks of you are implemented and deployed.

  1. Follow the guidelines in IEC 63365 ch. 5.1.2 "Symbol design" and put in the marking characters "IEC63365" at the bottom of the QR code
  2. Encode the AssetId as URI on top of the data in the QR-Code:
  3. Separate the manufacturerer address on the nameplate optically as indicated here
  4. Do not print the idShort on the nameplate
  5. Do not print marking texts and the marking icons simultaneously on the nameplate