MidKnightXI / opgg-ads-remover

Application that Removes Ads from OPGG Desktop Client.
52 stars 2 forks source link

not working after OPGG update #16

Closed BVLLISTA closed 1 year ago

BVLLISTA commented 1 year ago

not working after the latest opgg update (3-4 days ago).

huntervcx commented 1 year ago

Hi There !

Could you provide more information please ? as the template indicate :

Describe the bug A clear and concise description of what the bug is.

To Reproduce Steps to reproduce the behavior:

Go to '...' Click on '....' Scroll down to '....' See error Expected behavior A clear and concise description of what you expected to happen.

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

OS: [e.g. Windows, macOS] Version [e.g. 22] Additional context Add any other context about the problem here.

MidKnightXI commented 1 year ago

Hello,

Thank you for reporting that problem, but please do as said above, fill the template given as example when opening an issue to help us fixing it.

And avoid in the future to just add in description "it's not working, please fix" because it won't help us at all.

BVLLISTA commented 1 year ago

Describe the bug The script doesn't work anymore after the latest OPGG update which released 3-4 days ago.

To Reproduce Start OP.GG Desktop App, apply patch with [opgg-ads-remover], wait for 'Patched Successfully' notification, restart OPGG

Desktop OS: Windows 11

Screenshots Screenshot 2023-02-13 010931

MidKnightXI commented 1 year ago

Thank you for reacting that fast, I'm going to start working on it asap and keep you updated when it'll be fixed.

BVLLISTA commented 1 year ago

My thanks, sorry for opening an issue the lazy way!

MidKnightXI commented 1 year ago

The directory that was specified in the code where the ads were(assets/react) got removed and got replaced by a main directory containing main.js and preload.js.

Im still looking into it to find where the ad links are located with that new update but I guess we will have to work with that assets/main directory.

image
MidKnightXI commented 1 year ago

I think I identified where the ads are loaded, I'm going to start doing some tests to see if I can remove them tomorow

noahye1997 commented 1 year ago

2.0.6 doesn't work for USA ads image

MidKnightXI commented 1 year ago

2.0.6 only works for opgg on macOS atm because they haven't gotten the opgg update yet.

MidKnightXI commented 1 year ago

Also I think I'll wait for the update to roll out on macOS to test it better because rn I've to build everything on an arm windows virtual machine and it's a pain.

I'll continue to search for a fix but it will be longer than what I expected

BVLLISTA commented 1 year ago

OP.GG app received another update on Windows, V1.1.15

NaabKing commented 1 year ago

OP.GG app received another update on Windows, V1.1.15

Yes, and the new update is the worst one yet, ads are part of the app now, not seperate, the size is bigger and can't be resized anymore, i hate it. Hopefully this can be patched somehow.

MidKnightXI commented 1 year ago

Working on it, but I feel like it's going to be complicated to patch.

If anyone want to try to find a way to fix it:

You can also beautify the code by using beautifier to ease your work

MidKnightXI commented 1 year ago

Hello everyone, I asked Shyim for some help on that issue and he found a fix, go add a star to his project to thanks him 👑

I'll drop a new release soon after finishing some testing on my side to check if everything is working as intended 🐙