MidKnightXI / opgg-ads-remover

Application that Removes Ads from OPGG Desktop Client.
52 stars 2 forks source link

Client-based app features are not working after the patch is applied #30

Closed BVLLISTA closed 1 year ago

BVLLISTA commented 1 year ago

Describe the bug The League client based app features such as OP.GG pick, multi-search, champion, in-game, etc. don't work after applying the patch. The app stops detecting the status of the League client.

To Reproduce Steps to reproduce the behavior:

  1. Go to OPGG Patcher
  2. Apply the patch
  3. Run OP.GG
  4. Run League Client
  5. See the client is not detected by the OPGG app and your profile does not get loaded in to the app.

Expected behavior When the league client is opened, the summoner profile will get loaded in to the OPGG app's main page, and the app features will work properly on champion select and in-game, etc.

Screenshots

Screenshot 2023-07-25 212402

Desktop (please complete the following information):

MidKnightXI commented 1 year ago

I'm currently doing my own cloudflare worker, it might fix the problem. #28

Release: soon tm

potentate commented 1 year ago

also having this issue, thanks for still working on this. tired of op.gg using 30% of my cpu because of ads.

MidKnightXI commented 1 year ago

Quick update:

I'm wondering if I should deploy the next version like that even if there are still ads showing up but the live-game features are working fine and continue to work to improve it with time.

Either I could just leave it as it is today and keep working on it. I think it might take me some time to dig in how to change all of that as I should add some special routes to the worker for https://app.labs.sydney and analyze each items retrieved by it.

Also the Cloudflare Worker is only running on green energy, that's pretty cool :)

MidKnightXI commented 1 year ago

https://github.com/MidKnightXI/opgg-ads-remover/releases/tag/v2.3.0

You can try this version if you want your live features enabled