search

MidKnightXI / opgg-ads-remover

Application that Removes Ads from OPGG Desktop Client.
52 stars 2 forks source link

After patching, OP.GG displays a blank interface #32

Open Reprisal35 opened 1 year ago

Reprisal35 commented 1 year ago

Describe the bug After patching, OP.GG displays a blank interface with a league related background. Closing and reopening the app does not fix the issue. Reinstalling a fresh copy and running the patch does not fix the issue.

To Reproduce

  1. Install OP.GG
  2. Install OP.GG Patcher
  3. Run Patcher.
  4. Open OP.GG.
  5. See error.

Expected behavior OP.GG with an interface.

Screenshots Screenshot_447

Desktop (please complete the following information):

MidKnightXI commented 1 year ago

Hello thank you for opening the issue, which version of the patcher are you using?

Reprisal35 commented 1 year ago

I tired both 2.20 and 2.30, same result.

EDIT: Didn't want to double post. I tried on my laptop and the issue only occurs on 2.2.0. 2.30 works, but ads are still showing. I guess when I installed the 2.3.0 patcher, windows didn't properly uninstall the 2.2.0 files and applied the 2.2.0 patch instead of the 2.3.0 patch?

Screenshot_448 Screenshot_449

IKaeshine commented 1 year ago

I have same issue

Win 10 22H2

MidKnightXI commented 1 year ago

2.3 only removes some trackers to allow in-game features.

I guess they changed their endpoint to load the resources of the app.

I'm currently full time working + working on my graduation project so I can't tell you guys when it will get patched.

I'll take a look this weekend if I can.

MidKnightXI commented 1 year ago

If you are comfortable with web programming you can also check the network calls that the app is making when loading the resources and look what is getting called and failing:

To open DevTools, use the shortcut "Ctrl+Shift+I" or the "F12" key.

byotta commented 1 year ago

@Reprisal35 Try following the steps in this comment https://github.com/MidKnightXI/opgg-ads-remover/issues/21#issuecomment-1611734626

I had a similar issue and deleting the cached disk files seemed to solve it. You can run the official OP.GG uninstaller found somwhere in AppData foloder which will remove one of the folders, then you need to find the other and delete that one as well. Then reinstall OP.GG client and patch it again

Reprisal35 commented 1 year ago

@Reprisal35 Try following the steps in this comment #21 (comment)

I had a similar issue and deleting the cached disk files seemed to solve it. You can run the official OP.GG uninstaller found somwhere in AppData foloder which will remove one of the folders, then you need to find the other and delete that one as well. Then reinstall OP.GG client and patch it again

That does not fix it unfortunately, still shows a blank interface on OPGG version 1.1.29 using patcher 2.2.0, even on a fresh windows install. I have an older copy of OP.GG v1.1.17 that has no ads, and it looks like some functionality is broken, but the main components still work. I think I'll use that until they have time to look at it.

MidKnightXI commented 1 year ago

So I just tried the patcher in 2.2.0 this morning and I've the same problem than you do.

I'll try to patch it when I've time for it!

MidKnightXI commented 1 year ago

2.3.0 works, but ads are still showing. I guess when I installed the 2.3.0 patcher, windows didn't properly uninstall the 2.2.0 files and applied the 2.2.0 patch instead of the 2.3.0 patch?

The patcher in 2.3.0 do not remove the ads because they are linked to the in-game features endpoint of OP.GG servers atm and I didn't take time to analyze it properly. It was made to remove basic trackers and allow everyone to use in-game features.

You can check this repo to see what is done: https://github.com/MidKnightXI/opgg-patcher-worker

I created my own cloudflare worker because Shyim is not that active anymore so I can patch faster than he does (hopefully)

MidKnightXI commented 9 months ago

I'll look into that the next weeks, I've been pretty busy between work and school but I might have more time to work on this now.

Have you tried 2.3.0 in the meantime it should remove some trackers (from Google mostly) from the app

MidKnightXI commented 9 months ago

I just realized that something changed in their code since the introduction of 2.3.0 and it literally DDOS and saturate my worker that is supposed to patch the ads.

It's a cloudflare free plan so I couldn't let that happen because I'm limited to 100K request per day before paying from my pocket.

I decided to delete the worker and 2.3.0 in the meantime.

I'm working on a more aggressive adblocker at the moment based on ublock origin integration. I've no idea if it will work or not but I'm just tired of seeing ads for everything, if so, it should work for every apps on your OS.