search

MidLevel / Ruffles

Lightweight and fully managed reliable UDP library.
MIT License
212 stars 28 forks source link

refactor: Simplified logging #37

Closed gustavopsantos closed 2 years ago

gustavopsantos commented 2 years ago

Reduces nesting on hooking while making it easier for future hooks to be added.

TwoTenPvP commented 2 years ago

Looks good. Thanks for this!

TwoTenPvP commented 2 years ago

Only concern I have is:

  1. This is a breaking change due to the name change of CommonLoggers to UnityLoggers. Is it worth a major version bump?
  2. In order for the CI to automatically check the commit type, release a new version etc you need to follow semantic commits. Could you fix please.

Thanks @gustavopsantos

gustavopsantos commented 2 years ago

1 - This is a breaking change due to the name change of CommonLoggers to UnityLoggers. Is it worth a major version bump? Hmmm I didnt saw that, I dont think it is worth a major version bump, so Im gonna revert the field renaming I did.

2 - In order for the CI to automatically check the commit type, release a new version etc you need to follow semantic commits. Could you fix please. Sure

gustavopsantos commented 2 years ago

@TwoTenPvP I have applied the fixes for the concerns you had 😉

gustavopsantos commented 2 years ago

@TwoTenPvP Theres something else I need to fix? Thanks,