search

Midburn / spark

"burn in a box" suite of services that composes everything required to run a burn event throughout the year
Apache License 2.0
18 stars 46 forks source link

Update Spark version automatically #536

Open amotenko opened 6 years ago

amotenko commented 6 years ago

Every commit?

Every deployment?

ArtyomKa commented 6 years ago

deployment. in python there is a bumpversion utility. must be something similar in node. I can check...

ArtyomKa commented 6 years ago

OK. npm already has this functionality: https://docs.npmjs.com/cli/version Just need to add it to deployment script. Other suggestions?

OriHoch commented 6 years ago

I assume this is meant for ppl to know which version is deployed? you can know this from Travis but I can add another indication

because spark is not installed as npm package I didn't see a reason to keep updating the version in package.json

On Fri, Jan 5, 2018, 17:43 Artyom Katsap notifications@github.com wrote:

OK. npm already has this functionality: https://docs.npmjs.com/cli/version Just need to add it to deployment script. Other suggestions?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Midburn/spark/issues/536#issuecomment-355586065, or mute the thread https://github.com/notifications/unsubscribe-auth/ABJLBulH1qXzgjVJICdSEJXJWXE4VzpQks5tHkMzgaJpZM4RUj-g .

amotenko commented 6 years ago

It is super convenient, the version number is displayed and it's easy to tell just by looking which version is deployed

OriHoch commented 6 years ago

np I'll make sure there is a simple way to get the deployed version from the web app

OriHoch commented 6 years ago

ok, it works manually in the new production and staging environments

so, you can add some kind of bumpversion to the .travis.yml script, this script has a github token which you can use to push the updated version back to github as well