Midburn / spark

"burn in a box" suite of services that composes everything required to run a burn event throughout the year
Apache License 2.0
18 stars 46 forks source link

Updates to Suppliers #794

Open amotenko opened 6 years ago

amotenko commented 6 years ago

Suppliers should allow for distinction between types of suppliers. Each type has its own legal document to sign, and potentially a different default length of visa.

For 2018 we are requested to support two types of suppliers, regular suppliers and movers. Movers will sign a different document and will have a 3 hour visa by default, in contrary to the regular suppliers who have a 4 hour visa.

Technical details:

Better to do this with hard-coded values. This feature is new and likely to change.

flypunk commented 6 years ago

Should we really implement "When providing a document to download, provide one of the two according to type"? If a provider could be of a single type, there would be only one contract for provider, so there is no need to make a distinction on the API/DB level. @amotenko, what do you think?

amotenko commented 6 years ago

I agree and I apologize if I used unclear wording. There can be only one document to download for a given provider so there shouldn't be any ambiguity.