Midburn / spark

"burn in a box" suite of services that composes everything required to run a burn event throughout the year
Apache License 2.0
18 stars 46 forks source link

Clean global scope in controllers #998

Closed galnitsan closed 5 years ago

galnitsan commented 5 years ago

Proposed solution

  1. functions moved inside controllers.

  2. suitable names were named for these functions. the "old" names of functions were changed to the "new" names in all functions calls.

  3. 2 new services were create (factory) - (camps/suppliers).

  4. camps/suppliers services were injected to relevant controllers.

  5. camps/suppliers services were declared in layout.jade (under "spark scripts").

Tradeoffs

Testing Done

tested - ok.