Middle-Earth-Project-Team / modold

Fantasy mod for CK2 based on Tolkien's universe
12 stars 3 forks source link

Assemble the 7 kingdoms decision #59

Open Athoen974 opened 9 years ago

Athoen974 commented 9 years ago

As a dwarf player owning Moria, Erebor, and Gundabad (each being of dwarven culture), the following conditions were not met thus I could not call the assembly of dwarves : any_playable_ruler = { has_landed_title = c_erebor culture_group = culture_group_dwarves } any_playable_ruler = { has_landed_title = c_moria culture_group = culture_group_dwarves }
any_playable_ruler = { has_landed_title = c_gundabad culture_group = culture_group_dwarves }

Lonhaldar commented 9 years ago

Ok, looking at this.

Rigmored commented 9 years ago

I fixed the event and it fires properly, managed to get the Dwarvish Union, only issue is missing localisation in some events and problem with their gfx, the stylised letter don't show up

I'll commit the fixed decision

Lonhaldar commented 9 years ago

For the stylised letters, it needs a majuscul at beginning, Great to know that it works fine. Closed then?

Rigmored commented 9 years ago

Well, there is still missing localisations on lots of the events after the decision, in options mostly

What do you mean by Majuscul?

Lonhaldar commented 9 years ago

sorry, i used the french word. I meant, a capital letter.

Rigmored commented 9 years ago

Is the localisation fixed?

Rigmored commented 9 years ago

Fixed.

Athoen974 commented 9 years ago

Missing localisation in window 1 : option A Missing loc in window od event EVTTITunificatedwarves.5 : desc, title, option After wining the election, the law was copied from Durin's Folk (agnatick gavelkind) and not set to elective.

Rigmored commented 9 years ago

I think it's not meant to be elective, as the election is done by event, but I guess it should be elective

I thought I fixed these, one moment

Athoen974 commented 9 years ago

I think Lon wanted it to be elective every 20 years, but the last part was not done yet. Last time I did it, the crown laws were set to elective I think.

Athoen974 commented 9 years ago

After doing the event, the decision remains available. Could we add a condition to make it hidden once complete ? EDIT : Winning the election didnot make the remaining dwarven Kings my vassals

Rigmored commented 9 years ago

I've tested this 3 times and loc is okay, the decision does remain available, I'll fix that

I never had an issue with not gaining the title

Athoen974 commented 9 years ago

I won the title but the other Kings did not become my vassals.

Rigmored commented 9 years ago

I never had an issue with that either, the blue mountains, thrors coomb etc became part of Dwarvish Union

Athoen974 commented 9 years ago

I tried it again, but the Blue mountains and Nurukuzdin do not become my vassals

Lonhaldar commented 9 years ago

Some Kingdoms can refuse to join ;)

Athoen974 commented 9 years ago

Only if they did not vote for the elected king then ?

Lonhaldar commented 9 years ago

Normally yes.

Athoen974 commented 9 years ago

So the Kings probably did not vote for me but there is no way to know it for sure, is there ?