Closed CFlaniganMide closed 2 years ago
Merging #178 (8b1422b) into development (40a40c5) will decrease coverage by
0.15%
. The diff coverage is12.50%
.
@@ Coverage Diff @@
## development #178 +/- ##
===============================================
- Coverage 61.72% 61.57% -0.16%
===============================================
Files 34 34
Lines 2613 2621 +8
===============================================
+ Hits 1613 1614 +1
- Misses 1000 1007 +7
Impacted Files | Coverage Δ | |
---|---|---|
endaq/calc/shock.py | 83.10% <12.50%> (-4.04%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 40a40c5...8b1422b. Read the comment docs.
Couple comments @CFlaniganMide
https://colab.research.google.com/drive/1avKj__HojMguc215t8pX2lBgsPc4Q0AV?usp=sharing
A more big picture comment is that I am expecting to get these returned time segments in a way that will allow me to select the "best" ones within them. So for example I expected it to be ordered by peak value with those peak values visible so I can generate a histogram of the peaks
I think we can close this now that Connor isn't here and #190 is about to be merged in which provides this functionality
Really basic shock thresholding function to generate shorter clips of files for further analysis.
Should close #169 with a minimal solution.