MideTechnology / endaq-python

A comprehensive, user-centric Python API for working with enDAQ data and devices
MIT License
24 stars 12 forks source link

Feature/rolling spectrums #191

Closed S-Hanly closed 2 years ago

S-Hanly commented 2 years ago

Lots in this!

This would close / address: #189, #35, #156,

This specific branch is tested in this colab with lots of examples

codecov-commenter commented 2 years ago

Codecov Report

Merging #191 (760f41d) into development (9e720c4) will increase coverage by 0.02%. The diff coverage is 52.65%.

@@               Coverage Diff               @@
##           development     #191      +/-   ##
===============================================
+ Coverage        61.82%   61.84%   +0.02%     
===============================================
  Files               34       34              
  Lines             2656     2857     +201     
===============================================
+ Hits              1642     1767     +125     
- Misses            1014     1090      +76     
Impacted Files Coverage Δ
endaq/calc/shock.py 77.01% <9.52%> (-10.13%) :arrow_down:
endaq/calc/psd.py 67.87% <36.78%> (-21.75%) :arrow_down:
endaq/calc/fft.py 63.12% <39.13%> (-1.59%) :arrow_down:
endaq/plot/plots.py 40.75% <76.54%> (+24.52%) :arrow_up:
endaq/calc/utils.py 86.66% <100.00%> (+4.05%) :arrow_up:

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

S-Hanly commented 2 years ago

@CFlaniganMide let me know when you want to review this, I have the unit tests in there now and am curious how well written you think they are?

S-Hanly commented 2 years ago

@CFlaniganMide I think I've done everything now correctly, but let me know of course if not!

S-Hanly commented 2 years ago

Added! https://github.com/MideTechnology/endaq-python/issues/192