MideTechnology / endaq-python

A comprehensive, user-centric Python API for working with enDAQ data and devices
MIT License
25 stars 12 forks source link

Feature/test fixes #210

Closed StokesMIDE closed 2 years ago

StokesMIDE commented 2 years ago

A couple of fixes related to the unit tests.

Bonus fix: the Scipy URLs in various endaq.calc.fft corrected.

Note that as of the time of this PR's opening, the Windows tests run from the GitHub Action are inconsistently hanging and timing out for some reason. This does not seem connected to any changes on our end, or to libraries we use. It may be a temporary issue with GitHub's Windows environments. One timeout occurred while trying to install Python requirements, before the tests themselves even started.

Bonus feature: A timeout parameter has been added to endaq.ide.files.get_doc(). It was hoped that this would prevent the tests from stalling, but seems to have had no effect. It's a good thing to have in any case, however.

codecov-commenter commented 2 years ago

Codecov Report

Merging #210 (bbee830) into development (5f446dd) will decrease coverage by 0.15%. The diff coverage is 100.00%.

@@               Coverage Diff               @@
##           development     #210      +/-   ##
===============================================
- Coverage        70.59%   70.44%   -0.16%     
===============================================
  Files               34       32       -2     
  Lines             3095     3086       -9     
===============================================
- Hits              2185     2174      -11     
- Misses             910      912       +2     
Impacted Files Coverage Δ
endaq/batch/core.py 94.80% <ø> (ø)
endaq/calc/fft.py 72.14% <ø> (ø)
endaq/ide/files.py 76.57% <100.00%> (ø)
endaq/ide/gdrive.py 80.00% <100.00%> (ø)
endaq/plot/plots.py 66.88% <0.00%> (-0.67%) :arrow_down:
endaq/ide/__init__.py
endaq/__init__.py

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more