Closed tgipsonMIDE closed 2 years ago
Merging #115 (44a2eb1) into develop (0046600) will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## develop #115 +/- ##
========================================
Coverage 74.15% 74.15%
========================================
Files 10 10
Lines 3652 3652
========================================
Hits 2708 2708
Misses 944 944
:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more
This change doesn't break backwards compatibility when parsing the data, so maybe
DocTypeReadVersion
should not be incremented.
Fair point for the two tags added in this commit, but this bump will coincide with new ChannelParser/ChannelFormat behavior that will break current parsers, I thought you suggested emitting a future rev would prompt the user to upgrade ahead of the crash (I assume it will still fail, but at least they'll know why).
Fair point for the two tags added in this commit, but this bump will coincide with new ChannelParser/ChannelFormat behavior that will break current parsers, I thought you suggested emitting a future rev would prompt the user to upgrade ahead of the crash (I assume it will still fail, but at least they'll know why).
Fair enough, keep them both incremented. The difference between DocTypeVersion
and DocTypeReadVersion
(and when you would change one and not the other) seems a little vague.
This change doesn't break backwards compatibility when parsing the data, so maybe
DocTypeReadVersion
should not be incremented.