search

MideTechnology / idelib

Python API for accessing .IDE data recordings made by enDAQ devices.
MIT License
5 stars 0 forks source link

Feature/es 563 get range indices fix #138

Closed StokesMIDE closed 1 year ago

StokesMIDE commented 1 year ago

Fixes an issue with getting ranges with start and/or end times falling between ChannelDataBlocks. Also made getting an index for a time more reliable.

codecov-commenter commented 1 year ago

Codecov Report

Merging #138 (2852f66) into develop (2e987d3) will decrease coverage by 0.21%. The diff coverage is 76.19%.

@@             Coverage Diff             @@
##           develop     #138      +/-   ##
===========================================
- Coverage    74.48%   74.28%   -0.21%     
===========================================
  Files           10       10              
  Lines         3680     3690      +10     
===========================================
  Hits          2741     2741              
- Misses         939      949      +10
Impacted Files Coverage Δ
idelib/dataset.py 79.74% <76.19%> (-0.58%) :arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

StokesMIDE commented 1 year ago

This needs unit tests of the range-getting functions before it can be approved. Not having them got us into this mess in the first place.