No fail gives incorrect score - Githubissues

MidflightDigital / XX--STARLiGHT--twopointzero

Repository for the XX -STARLiGHT- twopointzero theme for Project Outfox and StepMania 5.1-git

GNU General Public License v3.0

62 stars 10 forks source link

No fail gives incorrect score #30

Open hahughes opened 2 years ago

hahughes commented 2 years ago

Describe the bug Failing a song with fail type off gives an A. Users are also still able to add to their score after they fail.

To Reproduce Steps to reproduce the behavior:

Open options -> Advanced Options -> Default Fail Type -> OFF
Play a song without hitting any notes (or very few notes) and "fail" it.

Expected behavior The final score should give the lowest evaluation possible. Instead the user is given an "A".

Desktop (please complete the following information):

OS: Windows 10
StepMania/Outfox Version
Theme Version: V2.1.0HF

Inorizushi commented 1 year ago

Thanks for reporting this!

Note(for myself): Probably check fail type and switch to grade by score or something