MidflightDigital / XX--STARLiGHT--twopointzero

Repository for the XX -STARLiGHT- twopointzero theme for Project Outfox and StepMania 5.1-git
GNU General Public License v3.0
64 stars 10 forks source link

Always get at least an A on post-song evaluation page #51

Closed 4rcadian07 closed 3 weeks ago

4rcadian07 commented 9 months ago

Describe the bug No matter what grade I get below an A, the evaluation page appearing right after the song is over shows an A. The correct grade is displayed afterwards at the song selection wheel. (Note - this is a similar but different bug from #30, as it seems to replicate in any fail mode and with any grade)

To Reproduce Steps to reproduce the behavior:

  1. Fresh install of Outfox 4.19 (no need to change any options)
  2. Install XX--STARLiGHT 3.0 beta 1
  3. Create a named profile
  4. Play any song (works with the Outfox credits song) and get enough misses for a low grade (e.g. C or D) (tried reinstalling and on two different Win 11 computers and always get this behavior)

Desktop (please complete the following information):

Additional context I'll try to see if I can replicate the bug with theme version v2.x

4rcadian07 commented 8 months ago

Example screenshots - song incorrectly rated as A+ on song eval, and correctly showing C+ on high scores afterwards.

Screenshot 2024-03-09 180914 - Copy

Screenshot 2024-03-09 181025

4rcadian07 commented 8 months ago

Update: this specific behavior can be fixed by updating OutFox\Save\ThemePrefs.ini, ConvertScoresAndGrades=true (or changing the corresponding setting in settings). So I guess the bug is that if ConvertScoresAndGrades=false, the recorded song grade doesn't match the post-song eval (and whatever the "non-converted" eval is, it is set super lenient to always give at least an A).

There is a separate inconsistency which is that even with ConvertScoresAndGrades=true, the high scores for each song still display the other grading system. @Inorizushi, could you point me to which lua file I could change that behavior in?