search

MidgetJake / UniversalDiscordNotifier

BSD 2-Clause "Simplified" License
4 stars 3 forks source link

Clue scroll config does not seem to work #4

Open neckothy opened 2 years ago

neckothy commented 2 years ago

Had multiple people encounter this issue. Still sends announcements even if the clue value is below the minimum value set.

edit: Seems to still send clue notifications even when unchecked, reproduced by a few friends.

Perhaps duplicate logic for this somewhere? I see two different calls to clueNotifier.handleNotify(), the 2nd of which doesn't seem to have any if (config.notifyClue()). Only glanced at code and don't actually know Java, so just tossing out a guess. My apologies if it's unrelated. call 1: https://github.com/MidgetJake/UniversalDiscordNotifier/blob/8eebad1df16df679021ae90f5667d77044f77f0b/src/main/java/universalDiscord/UniversalDiscordPlugin.java#L174 call 2: https://github.com/MidgetJake/UniversalDiscordNotifier/blob/8eebad1df16df679021ae90f5667d77044f77f0b/src/main/java/universalDiscord/UniversalDiscordPlugin.java#L260

MidgetJake commented 2 years ago

Thanks for taking a proper look! Wasn't quite to do with those calls. I had the check for the total value of the clue and the minimum value in the wrong place. so it was just removing any icons instead of not sending the notification.