search

MidnightPlugins / Lost-in-Midnight

A mission focused plugin for Endless Sky.
GNU General Public License v3.0
27 stars 5 forks source link

Bug in Hunting Beelzebub #17

Closed animoose closed 2 years ago

animoose commented 2 years ago

https://github.com/MidnightPlugins/Lost-in-Midnight/blob/e2f0831f747639d09065a534d28eda96df01c43a/data/remnant%20midnight/Missions%20Hunting%20Beelzebub.txt#L21

I think this should say attributes "south"

animoose commented 2 years ago

I checked this further and it ought to work with "south pirate". However what I found was that when I changed the line I could get the mission to trigger immediately while before I changed the line it never triggered, many visits to planet with the "south pirate" attribute.

MidnightPlugins commented 2 years ago

Thanks. It actually is intended to have attributes "south pirate". This allows for the mission to trigger at former pirate worlds in the south as well as southern pirate worlds with the "Pirate" government.

The mission had a 30% - "ignored" chance to trigger, so you could have just had unfortunate RNG.

To help address this, increased the initial offer to 70% while keeping subsequent deferred offers at 30% - "ignored paris".