search

MidnightPlugins / Lost-in-Midnight

A mission focused plugin for Endless Sky.
GNU General Public License v3.0
27 stars 5 forks source link

Cleanup: numerical delimiters, punctuation, typos #2

Closed TrebledJ closed 2 years ago

TrebledJ commented 2 years ago

This PR includes minor changes to the dialogue, including the addition of numerical delimiters (e.g. "1000000" -> "1,000,000", in line with ES convention), punctuation (e.g. comma/periods before ending double-quotes), and other typos.

MidnightPlugins commented 2 years ago

Thanks, I'll look over it.

MidnightPlugins commented 2 years ago

Thanks! Credited you in the latest update. Added most them manually. The ones where ' was replaced by " I left out to follow the style indicated in wiki for nested quotes. (https://github.com/endless-sky/endless-sky/wiki/WritingConversations).

This also gave me a chance to spot small errors I was unaware of and fix them. (ex: Thermopylae has fighter bays but I forgot to include the fighters!)

Thanks again!

TrebledJ commented 2 years ago

Ah, I didn't realise the " I replaced was being used in nested quotes, good catch.

If I may offer some advice on using GitHub:

  1. There should be a green button to merge the pull request. This would copy all the changes over to your repository, so that you don't have to manually add them. I'm not sure if you added the changes on your side one-by-one (which I imagine would be tedious). If the button shows yellow/red, there are probably some inconsistencies (merge conflicts) that need to be fixed.

  2. Merging doesn't offer too many benefits for a small repository, but it does help automate and organise the changes.
    One caveat though is that before merging, you may want to upload (push) your changes first, this might require fixing some merge conflicts in the pull request, which usually aren't too bad. After the merge, you'll want to download (pull) the changed files.
    Actually, all of this can be easily done with a git client (e.g. Github Desktop).

  3. If there's still stuff you wish to modify before merging (e.g. reverting my " changes back to ') or if you want to fix to any merge conflicts, then you should be able to edit my changes by going to the "Files changed" tab and clicking on "Edit file" in a file's dropdown.
    If you use GD, you can also edit the files locally ("<> Code" -> "Checkout with Github Desktop").

Hope this helps!