search

MidnightPlugins / Lost-in-Midnight

A mission focused plugin for Endless Sky.
GNU General Public License v3.0
24 stars 4 forks source link

"Gathering Specimens: X Lost" Missions Interfere with Minor Missions #3

Closed TrebledJ closed 2 years ago

TrebledJ commented 2 years ago

I've been using this plugin with a new pilot, but even progressing in the Remnant storyline, I am not offered the "Remnant: Learn Sign" mission from the built-in missions. It turns out that the "Remnant: Learn Sign" is a minor mission, which is only offered when no other missions are set to be offered.

It seems like the invisible, repeated "Gathering Specimens: XXX Lost" missions are interfering with any minor missions to be offered. After removing "Caelian" from the list of source planets from all the "Gathering Specimens: XXX Lost" missions (1, 2, 3, etc.), I was able depart, land, and be offered "Remnant: Learn Sign". (For testing, you may need to depart/land a few times, since "Learn Sign" is offered randomly.) No doubt this issue isn't isolated to just the "Learn Sign" mission, but also other potential missions in the listed source planets, labelled as minor.

I'm not sure what the purpose of these "Lost" missions are, but hopefully there is workaround.

Reproducible: https://gist.github.com/TrebledJ/7f5f63a2dc91be8f78fd73f7bb08f3e4

MidnightPlugins commented 2 years ago

I'll look into it. Probably have to set the Remnant portion of Gathering Specimens to happen after Remnant: Learn Sign.

UPDATE: Wow, it was more serious than I thought. A lot of Remnant mission chains start with a minor mission. My attempt at a fix is to make a token when the player boards a specimen creature. The associated "Lost" mission only triggers when a player has that token. The token disappears when the player turns in the specimen or lands on one of the origins asking for the seven specimens without the associated specimen.

The "Lost" missions are there to respawn the specimen creatures if a player accidentally loses a specimen before turning it in.

Thanks for alerting me to this issue!

TrebledJ commented 2 years ago

Hm... Another issue is that the "Lost" missions use require <outfit> 0, which is buggy in some cases. When I discovered the "Lost" bug here last week, I probably had the specimens in cargo instead of installed, so the Lost mission would trigger every time I landed. The same goes with other outfit recovery missions (e.g. the Thor one). But until require is fixed in the main, I guess I'll just have to remember to install stuff. Thanks for the fix.