MidnightPlugins
commented
5 months ago Thanks! A lot of issues is me putting missing files in the release but forgetting to add it to the repo.
Still too many dependencies on Midnight Scrapyard - There are some outfits where half the definition is in Scrapyard, but they should combine when running both plugins. Otherwise, I'm not sure what you mean.
Geddonian World Crusher or crystal sentries give no combat rating - I'm not sure what you mean by "give no combat rating"
Having frames 2 and 4 of the Geddonian World Crusher empty - Intentional; it was designed to take advantage of an error that made it invincible during frames where a ship had non-connected parts. That error has since been removed from vanilla. The blank frames are there to restore some of that invincibility.
mission "Thraal: Moreau (Failed)" - I'll update after testing to see if the error that failed to remove clearance from destination planet was fixed in the recent vanilla update
Double deadline on mission "Midnight Earth Retirement Inheritance" - Deadline by itself gives a deadline equal to the distance to the destination system. The extra deadline 1 should extend the deadline by one day in case the mission offered on Luna or Mars. Will test again to confirm this hasn't changed.
Map Paeli Patch - Intended to fix an error that no longer exists in vanilla; deleted the file
mission "Sheragi Shenanigans: Counterfeits" - Should offer after offered epilogue A; After some consideration I decided that there's no reason to make the player wait so added 4: declined as a possible pre req.
Image ship/cloaked - leaving error as is
Lone image "pirate scrounger@sw.png" in the thumbnails folder - Intentional for the shipyard thumbnail
Outfit "Test Drive" on the "Starcadia (Prototype)" - developer outfit; removed
Missing image "ship/station5ver8" - I put station images for all stations that spawn as ships in the ship folder because the game had problems with hit detection for some stations using the vanilla planet images; this is an example of an image placed in the release but overlooked in the repo
SomeTroglodyte
... excellent plugin.
IMHO what makes this excellent is that most of if just "fits" well into the ES universe - or is separate enough to ignore. :smile_cat: :rocket:
That said, here's a very unordered list of notes from me comparing a 2024-02-24 release download that I had patched to my pleasure with today's main branch:
(): Defaulting missing "drag" attribute to 100.0, has outfits:- no outfits listed. Can't find which ship definition if any trips this - no name, no outfits, no nothing... But the message is there with saves folder empty and only your plugin active, and not after disabling your plugin. I even patched ES to log missing baseAttributes.drag in Ship::Load and none was relevant... I believe there's a ES bug that it somehow loads a ship template where there's no ship keyword, but that's just a hunch. May be an empty-looking but actually containing tabs line somewhere..."year" == 3014not"year" = 3014- five instances. See patch below.not "Thraal: Moreau (Cleanup): declined"linenot planet Earthyou added fixes what I experienced? Maybe related to #21? I played it withdeadline 1removed - just fine.has "Sheragi Shenanigans: Sapphire Shield 4: declined"on the prerequisites to play it.The images I mentioned are in this zip: Lost in Midnight - images patch.zip You're free to use as you see fit w/o attribution - but sorry I haven't kept any upstream info where I took that spirit board from, so that probably won't do as-is.
The textual changes I mentioned as git patch - I can do a PR if you want, but the scope is small, so just copying or ignoring as you see fit is OK too. Some are just a suggestion like giving cost to the worldcrusher so trouncing it gives XP... And it's better you read them individually anyway.
Lastly: You seem to manage this entirely through the github web functions - in my experience such a repo can be maintained in the free android studio variant of jetbrains idea, just using its text editor, diff engine and git frontend - makes for much more readable commit histories... I can explain if you want. Or look under my repos for the scratchpad where I kept (sometimes outdated) notes how I use studio, maybe that helps.