search

MidoriKami / ChillFrames

Damalud FFXIV Plugin to dynamically limit framerate
Other
13 stars 6 forks source link

API to allow other plugin to request disabling of frame limiting #10

Closed Limiana closed 1 year ago

Limiana commented 1 year ago

Hey, would you like an API for ChillFrames to allow other plugins to request disabling of frame limiting?

MidoriKami commented 1 year ago

Not really, this doesn't fit into any kind of typical workflow for a user, and is likely to cause confusion.

If disabling ChillFrames is necessary for compatibility with other plugins you can use the dalamud command handler to invoke "/chillframes disable" and "/chillframes enable" as needed.

That said, my secondary reason for refusal is that I see such IPC making the internal logic of ChillFrames even more confusing (more double negatives and whatnot) if it is done in a clean way I would be willing to merge a PR.

Of note would be making it clear to the user that something else has taken control of the settings.

Limiana commented 1 year ago

https://github.com/MidoriKami/ChillFrames/pull/11

I think this should be not too messy

MidoriKami commented 1 year ago

image

Took a bit of a different approach. Should work fine.