search

MidoriKami / Mappy

Other
25 stars 14 forks source link

[Bug] Coordinates bar is 1px from the bottom #124

Closed zbee closed 4 months ago

zbee commented 4 months ago

The coordinates bar is 1px from the bottom of the map window.

image

Tried on various window sizes and positions.

Switching between Dalamud styles does not fix it.

MidoriKami commented 4 months ago

image I'm not seeing this myself

zbee commented 4 months ago

It's a font scale thing again: anything, up or down, other than 100% seems to cause this gap.

MidoriKami commented 4 months ago

Odd because I account for scale with every part of the calculation

        var coordinateBarSize = new Vector2(ImGui.GetContentRegionMax().X, 20.0f * ImGuiHelpers.GlobalScale);
        ImGui.SetCursorPos(ImGui.GetContentRegionMax() - coordinateBarSize);

        using var childBackgroundStyle = ImRaii.PushColor(ImGuiCol.ChildBg, Vector4.Zero with { W = System.SystemConfig.CoordinateBarFade });
        using var coordinateChild = ImRaii.Child("coordinate_child", coordinateBarSize);
        if (!coordinateChild) return;
MidoriKami commented 4 months ago

image

I still don't see it at 200% dalamud global font scale

zbee commented 4 months ago

Check the 117% button, or I'm on 91% personally. But yeah, don't see it on any of the other preset scale options, but do on every value between them it seems.

Probably the same thing we discussed about SortaKinda though.

zbee commented 4 months ago

Were you not able to reproduce on the 117% preset, or any custom value? If so I'll keep investigating the issue. Or is only 100%+200% font scale support planned? If so I'll work on a PR.