search

MidoriKami / Mappy

Other
22 stars 13 forks source link

fix: quest objective opening wrong map location #167

Closed kasuriax8 closed 2 months ago

kasuriax8 commented 2 months ago

Primary fix is in CustomQuestSheet.cs w/ the index of ToDoLocation[0][0] changed to 1222 instead of 1221

I noticed the that OpenMapInfo MapId was correct so Open Map now defaults to using the initial value and only tries a look up if the mapId is 0

GetMapIdForQuest has been changed to allow lookups for hidden quests. This would fix the case where an individual disabled tracking a quest but revisits it in their journal to find the quest location.

Note: Temporary markers persisting when changing areas via clicking visible green arrow connections on a map is ongoing

MidoriKami commented 2 months ago

The temporary markers issue is a tough one, on one hand it makes it really easy to center on the marker if we are in the correct map, but it makes it tough because it doesn't contain any information on which map it belongs to.

MidoriKami commented 2 months ago

Really nice catch on the shifted ToDoLocation, I suspected there was something going on there, but didn't have to willpower to find out what exactly =D