MidoriKami / Mappy

Other
22 stars 13 forks source link

adds check to prevent temp marker draw if not on initially called map #168

Closed kasuriax8 closed 1 month ago

kasuriax8 commented 1 month ago

This may be a possible fix to the persistent temp markers... After taking a look at simpleTweaks Debug, I noticed that when the map is called via quest log, the Map Agent has prop SelectedMapSub set to the mapId to be shown, SelectedMapSub does not change when clicking on green map connections. When opening the map via hotkey or normally, SelectedMapSub dynamically changes with the currently showing mapId.

My assumption is that if temp map markers are only generated when clicking on Quest Log, Gathering Log, Hunt Log etc then the MapAgent will display a mapId and lock the SelectedMapSub to that mapId. Blocking temp markers from being drawn if SelectedMapSub != MapId will prevent temp markers from persisting across connection/view parent clicks

MidoriKami commented 1 month ago

Implemented fix directly in local env