search

MidoriKami / NoTankYou

FFXIV Dalamud Plugin, Shows a "Tank Stance" warning if no tanks in your party have their tank stance on.
Other
13 stars 13 forks source link

More basic instinct edge cases #39

Closed quisquous closed 1 year ago

quisquous commented 1 year ago

(I am on v5.0.3.7, which I assume has the fix from #37.)

I think "bound by duty" is not fully the answer. You can be in the overworld and do a battle leve which makes you bound by duty, but basic instinct can't be used there because you're still in the overworld. Also, carnivale is a solo instance where you are bound by duty but basic instinct can't be used there because it's not content meant for more than two people.

Maybe a blacklist of territory ids? (I could give you a list if that'd be helpful.) Or do a more dynamic territory id -> content finder condition / content type lookup from game data to only show basic instinct in territories for party content?

MidoriKami commented 1 year ago

Either I remove the basic instinct feature entirely or I leave it as it currently is.

I am not adding special handling like that.

MidoriKami commented 1 year ago

I might revisit this later but blue is extremely annoying to deal with.

I'm not adding anything that requires being updated for a patch to continue working correctly. A cfc lookup for a particular battalion type might work but I am not going to spend the time on that right now I have other projects I'd rather work on.

A PR would be potentially accepted.