Closed zbee closed 8 months ago
Apologies, I thought I solved this multiple times, each fix working in vacuum, removing empty rules worked once but not afterwards (or likely didn't test it fully, now I don't even know).
I retried with removing each rule, eventually finding the "culprit" ... or so I thought.
These are all of my rules, which I have been using for a while:
H4sIAAAAAAAACu2aa3PbxhmF/woGX5pM1+7eL/omy5d6xoo9lpO0zeTDLrArYQwRLAja1qT57z0LkiZDijbjqklTUSPOEMCLBS/Pe3D2LH/4qXw+qdr5rHkXTyd1eZJ8O4ukPOvari9Pfir/Vp6wh5SUfy9P6EPBuROCclL+I29yKZSi0pLy+7HqZ1I+xxBlCEEGXrNoHJWyEs47FRVPshasdpUvSfmNv46ofNRcPGhmV8UjPwxtLJ5F3+Pg80kdP2BEUp62bfc+1s+HeJ3PmJUnP/z4cW/e8zpexg9b+3P1m5vpLXtf+74ZmtWBvOdFfBfbp007xPHdPpn40OKFDf0cH8ILH2KLV5kLi7GyWJaS8tx/+M63c9QySvH5nDeT5bZW+YP4Lk7qrn/VN1XcHX75Ia/GX9QWY/G+K2xdJF/i28nQ+zqPuL7CxeCHfJiUq32Lyuaf809W8Z/H77yN1fC5AQVKH9/Ez5UxlL2OU9/0n6uUecCmx6WbbjJ+7TjSnnf1ouyi64fFBoY8AFf6UDGppXF6SS3TlCkp2JJaxqxyzLJtan1FQ9IyRBGS9DwFE500wTHsq62Pa2rP5n0fJ8N+cvkfg1yQ+gtw2RHc3xdcQalwQvEluNRKJ6RZgUs1pVwzsw0uc7X2ihtT+SilB7UVlSwFR/HPjV6D+3K4iv3tyIo7QFZIIhQRhghNhCWSEUmJ5EQKwqjDw+Jh8NB4KOIscYagTa0j1hJriJUET4khmiiCwQgnjDD2W7QC25HXo4LfSSOwL1JwqpjL4I994BhX0q1ch6TOWMf1dhvYVFnBdRCWGpmiCynKZI2BiHupU7Vug8fdX//yoph0w4Oh69pZ4YcCjVGEbhi663VLyFtbonz45+KrLhVnvU9DM7n8F54/87mxsPF1+ZuI/JZ/+HX+5Mj2fyLydC/b9HC2reXyI9vCcKU+sm0snIrcZpsbq5OsYFGElQr2xDKZ6ipYobk1Fd9m+5NcqzuQes4Ip4RBnyHSlnCoO0Qd2i4Jg7I7IjiB4xKUcEPQq1wRvGWOYpyC24A7kn//yGdUMKNx51+gr7njVCi9ZN85pbmRO7pugk4hUE6dpzKhQVgtlAT/lXFGO7Zm/wle9qQZbkhxHifTq2biSfG0bzC7ml0103UD6NuFfXV68RpKniV0OcifZsUT3/eLnevxirOmr9o4HCX/PoFPvwR8o7QF26sJqbKw+RDCBfdGjH9qm/tYixA8ZqSUIU4JJjCXrK8Uq2sZkxFr7i+6eQs/cjMbcPE15uYOdF7zo1DfP14dd5IxY5a82mxYoLlLYLXInmXXf9fIAmnAHBU6bVON/IQGTEa10snUYUOn33QgbANUe7sej2W/Ul31l04Wj5b6f5BXeSCvljkNY7AyFmLUVxjSBa+WZfkVO7zCO1eOeRkRV3PvglIucp2s4raSVq15Pe2vEc8+7rvpBrTuDtQVJhohh0TYocmYfiADyQEIApEciyzykRyaqGVoksOTvA1//amsBZnJ6M1hxnEW7DlsOB8NOJy4za5cjM4dVj17dkeynRejSYdbx+AMFn5vI+XXjMsR819LIo9T1N83h5S5fdRK/lm+F+i8zDO2k6Au99dOP3nP6iRtRZUIUrPkU53qiCc8RhNDvZGfdynFfqOXcvh22x1gUXg02EeD/bkbgJEKWC6BNSOwq0wFyz85VOE7q5RcwmILhIRYLap5QhKjVOTK82hU9Bv++hwN1zd+g9e7WJpU0HlxdCv3z11rw6lyK7MCt+GwzLNa49mhVNgotEseUMuaYq0nKHiWKrGaIQdMa0pfdUNxMZ9OW9yli696//7rDWBvX5EsL97HOBSn7c1sNs8J4bco7y/7bj6pi4tpjjyK7zP8OPRiPsGzfLx41Haz2ZgonrbVVXxw3cyOKcghIs0PSkH44dzzP5JL12ZMvtfg50mm3Qe+q6sKxjxKZ6L0aINKBJao5b5KIlCxD/wqr8vEehP+29c2y2f4mmKhiosBq/mXwxX64K2/ikeW7zHLh2q4tFYypNWrGSc1WICncq+KwxxjfbLCGj2WcWRyPDE3GmYnfAgbMD/tunq/jO9Zknza+8nQNR0qoc0Y4E137Ye8ieB6uAp99G+L05gXKWce74mUzxqcUbzqpt1Y9vJdE7pZcd60b7H12PdviyeXl9MWRUf3fW+b4VBhlw6+RCOYWDXDmBfqfc1AA+PJW0qZ15LT5CKltUBTsIhsm+9vhlukXX26IYqXTZtp930b/aQ4u4pxFo9E31uiD5V3zn85ocy/P/n4s1eTwxHtdjReW1kZRB8eP9qqjfMxUNh0/ArWCJ/Exu8H3/RN8G2Rid0MQfQdTCqR0khFENWrezq1XIRf/38LjT/+GymbvNeqLQAA
The "Food Supplies ..." rules seemed to be the problem, but they're also some of my oldest sorting rules, so ... I'm not clear on why these broke recently, I don't recall editing any rules recently.
I tried narrowing these rules down by adding item types, an tried changing the other settings in the rules, but nothing fixed it, and no other rules seem to overlap heavily, nor does removing any other rules seem to fix it.
But removing them also worked only the one time, seeming to point to a Conflicting Plugin, but at the same time, I can only get it to work the one time at a time by editing rules, seeming to suggest to me that it is the rules ....
Is this a conflicting plugin somewhere then?
I tried unloading each of these one at a time, and all at once:
Starting without 3PP plugins also changes nothing.
dalamud.log while trying to fix this from the sorting rules side of things
Catching and explaining this error as "Broken rules / Conflicting plugin" is still ideal, of course.
I believe you're misunderstanding the error being logged. It refers to my code making modifications to data that I manage in an improper way. It does not mean that other plugins are doing something to interfere.
I'll take a look, thanks for the report.
In the last few days SortaKinda stopped working for me at all with the below error, and I went through numerous attempts to try to fix it,
but ultimately it was just because I had an empty Sorting rule.I think this error should be caught and explained to the user -assuming it can be narrowed down, on the assumption that this error would also be thrown if a similar plugin were actually blocking SortaKinda, which is what I tried to find and disable in my trubleshooting-, or empty rules should be deleted on closing them, or simply ignored when running sort.
Log when trying to sort manually
``` 01:02:38.562 DBG | [SortaKinda] Sorting Inventory: ArmoryHead 01:02:38.562 DBG | [SortaKinda] Sorting Inventory: ArmoryBody 01:02:38.562 DBG | [SortaKinda] Sorting Inventory: ArmoryHands 01:02:38.562 ERR | [SortaKinda] Exception Source: SortaKinda :: SortaKinda.System.InventorySorter :: SortInventory 01:02:38.562 ERR | [SortaKinda] Exception Source: SortaKinda :: SortaKinda.System.InventorySorter :: SortInventory 01:02:38.562 DBG | [SortaKinda] Sorting Inventory: ArmoryLegs 01:02:38.562 ERR | [SortaKinda] Exception Source: SortaKinda :: SortaKinda.System.InventorySorter :: SortInventory 01:02:38.562 ERR | [SortaKinda] Exception Source: SortaKinda :: SortaKinda.System.InventorySorter :: SortInventory 01:02:38.562 ERR | [SortaKinda] Exception Source: SortaKinda :: SortaKinda.System.InventorySorter :: SortInventory 01:02:38.562 ERR | [SortaKinda] Exception Caught During Sorting 'ArmoryBody' 01:02:38.562 ERR | [SortaKinda] Exception Caught During Sorting 'ArmoryHead' 01:02:38.562 ERR | [SortaKinda] Exception Caught During Sorting 'ArmoryHands' 01:02:38.562 ERR | at System.Collections.Generic.Dictionary`2.FindValue(TKey key) 01:02:38.562 ERR | System.InvalidOperationException: Operations that change non-concurrent collections must have exclusive access. A concurrent update was performed on this collection and corrupted its state. The collection's state is no longer correct. 01:02:38.562 ERR | System.InvalidOperationException: Operations that change non-concurrent collections must have exclusive access. A concurrent update was performed on this collection and corrupted its state. The collection's state is no longer correct. 01:02:38.562 ERR | at SortaKinda.Models.SortingRule.<.ctor>b__3_1(IInventorySlot slot) in /work/repo/SortaKinda/Models/Configuration/SortingRule.cs:line 32 01:02:38.562 ERR | at System.Collections.Generic.Dictionary`2.FindValue(TKey key) 01:02:38.562 ERR | at System.Collections.Generic.Dictionary`2.FindValue(TKey key) 01:02:38.562 ERR | at System.Linq.Enumerable.All[TSource](IEnumerable`1 source, Func`2 predicate) 01:02:38.562 ERR | at SortaKinda.Models.SortingRule.<.ctor>b__3_1(IInventorySlot slot) in /work/repo/SortaKinda/Models/Configuration/SortingRule.cs:line 32 01:02:38.562 ERR | at SortaKinda.Models.SortingRule.<.ctor>b__3_1(IInventorySlot slot) in /work/repo/SortaKinda/Models/Configuration/SortingRule.cs:line 32 01:02:38.562 ERR | at System.Linq.Enumerable.All[TSource](IEnumerable`1 source, Func`2 predicate) 01:02:38.562 ERR | at System.Linq.Enumerable.All[TSource](IEnumerable`1 source, Func`2 predicate) 01:02:38.562 ERR | [SortaKinda] Exception Caught During Sorting 'Inventory1' 01:02:38.562 ERR | System.InvalidOperationException: Operations that change non-concurrent collections must have exclusive access. A concurrent update was performed on this collection and corrupted its state. The collection's state is no longer correct. 01:02:38.562 ERR | at System.Collections.Generic.Dictionary`2.FindValue(TKey key) 01:02:38.562 ERR | at System.Linq.Utilities.<>c__DisplayClass1_0`1.Reproduction dalamud.log