search

MidoriKami / ZodiacBuddy

11 stars 9 forks source link

[Bug] Dungeon incorrectly shown as bonus #29

Closed choreutes closed 2 months ago

choreutes commented 1 year ago

I'm experiencing the opposite issue to #26. I just ran Brayflox's Longstop (Hard) as it was shown to give bonus light, but got bright light afterwards which is the non-bonus light iirc.

Time of occurence: 2023-03-27 22:29 CEST / 20:20 ST

grafik

Hiroa commented 1 year ago

Yeah 32 is not a light bonus for Brayflox (Hard). I have some ideas of how it could happen. I need to try them tomorrow.

DoubleMCA commented 1 year ago

This is still happening.

https://imgur.com/a/4bmi41Q

Hiroa commented 1 year ago

Well, I agree on the false report, but at this point it's more a bad luck and latency issue.

2023-04-06T10:03:59.386 [info] [ZodiacBuddy:18014598547373670] New report: {"datacenter_id":7,"world_id":33,"territory_id":172,"date":"2023-04-06T10:01:31.3801077Z"}
2023-04-06T12:05:46.204 [info] [ZodiacBuddy:18014498558748530] New report: {"datacenter_id":5,"world_id":35,"territory_id":172,"date":"2023-04-06T12:00:00.3360275Z"}

Someone should have enter the duty just before the window reset (cf 2023-04-06T12:00:00.3360275Z).
Maybe the server of SE have make the duty start at 11:59:59 but because of the lantency, the game get the response at 12:00:00.
May also be a latency between the real start of the duty and the event "duty start" trigger by dalamud. We could do nothing about that other than ignoring report that are XX seconds after the bonus window changed.

DoubleMCA commented 1 year ago

Would it be possible for the addon to detect that the bonus is not in effect any longer and remove the bonus light message?

Hiroa commented 1 year ago

It's possible, but I would keep that as a last option. I'm confident that should not be needed.
Will trying to fix the cases of player reconnecting during duty or joining an ongoing duty, I have made the detection worst for the normal cases that has lead to the case of today.

MidoriKami commented 2 months ago

Is this still an issue?