Midtrans / midtrans-go

This is the Official Go API client/library for Midtrans Payment API. More information about the product and see documentation at http://docs.midtrans.com for more technical details
https://pkg.go.dev/github.com/midtrans/midtrans-go
MIT License
93 stars 25 forks source link

fix installment_term json parse field #29

Closed kevinkjs closed 1 year ago

kevinkjs commented 1 year ago

Noticed on wrong installment_term field in transaction_status response struct.

check status response should be like this

{
    "masked_card":"47737760-1650",
    "approval_code":"1662086003735",
    "bank":"bca",
    "eci":"05",
    "installment_term":24,
    "channel_response_code":"0",
    "channel_response_message":"Approved",
    "three_ds_version":"1",
    "transaction_time":"2022-09-02 09:33:08",
    "gross_amount":"230000.00",
    "currency":"IDR",
    "order_id":"03-16620858337043",
    "payment_type":"credit_card",
    "signature_key":"2f217f1356725fb227ad8b35bc6db0349021def58326f5f6f6c5d2eca572a289c1a9ae6c7cd21d54b18e529ae76c3f3ddf2fe8aa05109f94332726dad2ed3b22",
    "status_code":"200",
    "transaction_id":"f997d6ba-af8c-4d31-b159-d74f522ca5d1",
    "transaction_status":"capture",
    "fraud_status":"accept",
    "status_message":"Success, transaction is found",
    "merchant_id":"G182508043",
    "card_type":"credit"
}

Changed from installment_terms to installment_term

Linked issue : https://github.com/Midtrans/midtrans-go/issues/21

Xaxxis commented 1 year ago

Dear @kevinkjs

Thank you for submitting your pull request to our Midtrans-Go project! We have reviewed your changes, and we are pleased to inform you that the issue you addressed is valid, and your pull request is now under review by our team.

We greatly appreciate your contribution to the project and your commitment to improving its functionality. Your efforts are invaluable to us, and we will work diligently to thoroughly assess your changes and provide constructive feedback or merge the pull request if it aligns with our project's guidelines.

Please be patient while we carefully evaluate your contributions. We encourage you to stay engaged and open to collaboration as we work together to improve our repository.

Once again, thank you for your dedication and enthusiasm toward enhancing our project. We will get back to you as soon as the review process is complete.

If you have any questions or concerns, please contact us via the pull request thread

Happy coding!

kevinkjs commented 1 year ago

thank you @Xaxxis 🥳