Don't need root on macOS

MightyCreak / diffuse

Diffuse is a graphical tool for comparing and merging text files. It can retrieve files for comparison from Bazaar, CVS, Darcs, Git, Mercurial, Monotone, RCS, Subversion, and SVK repositories.

http://mightycreak.github.io/diffuse/

GNU General Public License v2.0

260 stars 46 forks source link

Don't need root on macOS #173

Closed krlmlr closed 1 year ago

krlmlr commented 1 year ago

At least not on my machine.

Includes a change to make the build/ directory very explicit.

MightyCreak commented 1 year ago

You need the build/ directory to build, test and install Diffuse. That's why I cd build before running the meson command-lines. I don't really see the benefits of asking the dev to go back to the root (build/ parent) if the next command to install Diffuse requires you to go back into the same build/ directory.

Right now I would lean toward no accepting the changes, unless there is a reason I don't see?

krlmlr commented 1 year ago

Thanks, I reduced the PR to the part I really care about.

MightyCreak commented 1 year ago

Since I don't have a Mac, I'll let your iron out the details here before merging. It seems there are a few questions pending:

Where exactly does the app is installed? (why does meson take the HOMEBREW_PREFIX env?)
Is it possible to run Diffuse on the command-line without having to use diffuse_impl?

For the last point, could it be that a shell wrapper should be installed in something like /usr/local/bin and it would take the command-line arguments and pass it through the Mac application? (There must be a way to send arguments to a Mac application, right?)

MightyCreak commented 1 year ago

Fixed a few remaining changes that I didn't really agreed on + some markdown refactoring to comply with the linter. Will merge once pipeline is green