Use Python GTK best practices

MightyCreak / diffuse

Diffuse is a graphical tool for comparing and merging text files. It can retrieve files for comparison from Bazaar, CVS, Darcs, Git, Mercurial, Monotone, RCS, Subversion, and SVK repositories.

http://mightycreak.github.io/diffuse/

GNU General Public License v2.0

260 stars 46 forks source link

Use Python GTK best practices #184

Closed MightyCreak closed 1 year ago

MightyCreak commented 1 year ago

I created a Python GTK project with GNOME Builder and saw how they split the application and its window.

In this PR I:

Renamed class Application to DiffuseApplication
Renamed class Diffuse to DiffuseWindow
Moved DiffuseWindow class to its own file
Moved PaneHeader/Footer outside DiffuseWindow
Moved FileDiffViewer outside DiffuseWindow
Removed unnecessary constructor parameters
Added docstrings

Thanks to these changes, main.py is now < 400 lines! :tada:

MightyCreak commented 1 year ago

@yuriiz or @krlmlr: would you like to review this PR?