Remove lasting deprecation warnings #55

MightyCreak / diffuse

Diffuse is a graphical tool for comparing and merging text files. It can retrieve files for comparison from Bazaar, CVS, Darcs, Git, Mercurial, Monotone, RCS, Subversion, and SVK repositories.

http://mightycreak.github.io/diffuse/

GNU General Public License v2.0

265 stars 45 forks source link

Remove lasting deprecation warnings #55 #96

Closed yuriiz closed 2 years ago

yuriiz commented 3 years ago

Remove usage of deprecated Gtk.IconFactory & Gtk.ImageMenuItem

https://github.com/MightyCreak/diffuse/issues/55

MightyCreak commented 3 years ago

I like that! Thank you for your contribution, when I have time, I'll test it locally before merging it.

krlmlr commented 3 years ago

Confirming that these changes work for me.

MightyCreak commented 3 years ago

I've tested locally and it doesn't work. I indeed don't have the warnings anymore, but I also lost the icons these lines were creating:

Before:

After:

yuriiz commented 3 years ago

I could not reproduce it. What distro and GTK version? Does changing icon names to not deprecated ones fixes anything? For example, GTK_STOCK_EXECUTE -> "system-run" as described at https://developer.gnome.org/gtk3/stable/gtk3-Stock-Items.html#GTK-STOCK-EXECUTE:CAPS

MightyCreak commented 2 years ago

Hi @yuriiz !

I'm finally giving some love to this project ;)

To answer you questions: I'm on Fedora 34, and maybe using the non-deprecated name works, it's worth a try.

Also, here's the new link for the GTK_STOCK_EXECUTE documentation: https://docs.gtk.org/gtk3/const.STOCK_EXECUTE.html

MightyCreak commented 2 years ago

Since we don't have the warnings anymore (see https://github.com/MightyCreak/diffuse/issues/55#issuecomment-1127777620), I'll close this PR.