The Template Class compatible with 3.2.x

[orynider]

Hi,

Take a look at: https://github.com/MightyGorgon/icy_phoenix/blob/master/includes/template.php

And: https://github.com/Mx-Publisher/mxpcms/blob/master/includes/template.php

Specially at function compile_code() :-)

[vendethiel]

It has comments from MG, yes. What’s the purpose of this issue?

[orynider]

I see that You added TAG_HOOK. You could add INCLUDEJS and INCLUDECSS by merging the two.

[vendethiel]

Is MxpCMS based on MG's mods?

[orynider]

There is mx_smartor witch is based or developed along MG's "Full Album Pack" then there is mx_pafiledb witch is not in our main core modules but at MXP is a official module outside the "Core", then there is mx_kb that on both IP and MXP are addon modules.

MXP's internal backend is based on phpBB2, then phpbb2 backend is working atm with phpBB2Mx, then the other bakends are based on phpBB3+, but we have some ACP files that look very the same plus the Template Class is very close on phpBB2Mx and IP and MXP.

There are more addon modules that are based on phpBB2 or phpBB3 mods at https://sourceforge.net/projects/mxpcms/files/ :-)

[MightyGorgon]

Thanks for your suggestion, but in TPL it's already possible to include anything by using PHP, what's the purpose to add INCLUDEJS and INCLUDECSS? In Icy Phoenix there is also a specific way for doing that by using these vars (includes/template.php): var $css_style_include = array(); var $css_include = array(); var $js_include = array();

The way to use those is something like this: $css_temp = array('my_css.css'); $template->css_include = array_merge($template->css_include, $css_temp); unset($css_temp);

So every CSS and JS is properly included in the header of the HTML.

[orynider]

The suggestion comes after I seen that any phpBB 3.2.x style can work also with MXP ignoring the events atm. This was happening 15 years ago when new users uploaded phpBB2 templates in MX-Portal 2.7 and then asked for support since they had problems with the navigation. In reality just some template files are needed from the phpBB style. This was funny to let users decide were to upload each type of style. :-)

There is also the lang() function that now works by strreplace it back to "L..." and the events that I most do as in 3.2.x so that I can make styles for both CMS and Forums.

[vendethiel]

Icy Phoenix already has support for L_ replacement (I think eXtreme Styles adds that, not sure).

[orynider]

Icy Phoenix already has support for L_ replacement (I think eXtreme Styles adds that, not sure).

Yes, but since phpBB 3.1.x there is the template lang() and "L_" is deprecated.

[vendethiel]

phpBB 3.1 uses a template system based on Twig, and rewrites old-style construct with new style. It's 100% different.