search

MightyGorgon / icy_phoenix_plugins

Plugins for Icy Phoenix
http://www.icyphoenix.com
7 stars 6 forks source link

ACP>Missing some lang keys #8

Open vendethiel opened 9 years ago

vendethiel commented 9 years ago

Some stuff is hard-coded in there:

# adm/admin_kb_cat.php, ~L155
echo "Please put a category name in!";

#~ L164
mx_message_die(GENERAL_MESSAGE , 'Select a Forum');
MWE001 commented 8 years ago

You know, I have to call it the way I see it. That is just wrong putting that code in like that. However, it is in my opinion that it really don't matter. Wrong yes, matters no. Why? You know me, I have to get up under the hood when i can. So here I go!

I went to the KB and went to categories. First off, I have to put in a category name to create a category. Next, the only way I WON"T have a category name is if I backspace it on the next page. I can fill in all info like permissions and what forum to post comments to and submit and wah lah! Category is created without a name. I do not get the echo message at all. Now if I make sure it is set to Forum ID = Select a Forum and not choose, if I submit, I do get the message die error that echos Select a forum.

Yes, it really should be language files. I checked back in my old phpBB mods folder and this issue goes back to the beginning of time with this mod basically and no one caught on to it and ever fixed it.

Nice catch!

MWE001 commented 8 years ago

I tried for a good hour or two to get this fixed. I had mostly all white screen of deaths, BUT on one occasion I had a positive submit only missing my language key for some odd reason.

After that positive submit I dug a little deeper and even more white screen of deaths. As I said over at my integra repo, since it has the same exact missing language keys, I am going to hang on to the code I used and give it a try again later.

And for the record, I might need a quick $0.50 lesson on why my language key failed to print on screen. That one baffled me.