MightyHive / chrome-extension

0 stars 0 forks source link

Tech Debt: Convert Full Report to use connections #9

Closed jreidgreer closed 7 years ago

jreidgreer commented 7 years ago

Scope

full-report, background-script

Category

Tech Debt

Description

While the Popup script was converted to using long connections a bit ago for live updates, the Full Report app still uses the older single-message communication method. This means that the Full Report will not update if new items are found. In addition, the old architecture to support this needs to be cleaned out of the Background Script, since it's messy and difficult to understand 😬 .

Unlike the Popup script, however, the BG Script needs to be able to listen for navigation events and disconnect from the connection. Users probably don't want their Full Report to update when they navigate in another tab. The current connection helpers don't support this, so updates will need to be made to the Utils most likely.

Acceptance criteria

Update the Full Report app to use long connections and ensure it doesn't update after a navigation event.

jreidgreer commented 7 years ago

Acceptance criteria met, but the legacy methods need to be cleaned out. I'll make that another ticket, however.