Allowing manual values to be quickly entered but accepting default values as fallback

MightyMoud / sidekick

Bare metal to production ready in mins; your own fly server on your VPS.

https://www.sidekickdeploy.com

GNU General Public License v3.0

5.97k stars 98 forks source link

Closed dejanstrancar closed 1 hour ago

dejanstrancar commented 2 weeks ago

Currently default value is initial value, and for example in case of selecting a domain you need to delete whole value before inserting a wanted one.

Default value is a good approach, but prompt should allow you to insert manual entry quickly if needed.

Also did a bit of refactoring of GetDefaultTextInput usages since it was repetitive code.

dejanstrancar commented 2 hours ago

@MightyMoud thoughts? I would otherwise simply close the PR as not being accepted.

MightyMoud commented 1 hour ago

Hi @dejanstrancar I apologise I was away for holiday and came back to lots of work in my day job.

I really like the approach you took here. Thanks for your contribution.

Could you please resolve the conflict and I'll merge this in afterwards?

MightyMoud commented 1 hour ago

All good, I have resolved them. merging this in. I will make a release this week with those changes.

Thanks again! <3